[arch-dev-public] [signoff] udev 157-1, initscripts 2010.06-1, mkinitcpio 0.6.5-1

[Thomas Bächler]

Am 04.06.2010 19:48, schrieb Roman Kyrylych:
>> Booted fine under Xen using stock Arch kernel (via pv-grub),
>> so I signoff x86_64.
> 
> Noticed the following:
> 
> +if ! /bin/mountpoint -q /dev; then
> +  if grep -q devtmpfs /proc/filesystems 2>/dev/null; then
> +    /bin/mount -n -t devtmpfs udev /dev -o mode=0755,size=10M,nosuid
> 
> 1) grep should be /bin/grep

Shouldn't matter actually.

> 2) /dev/null does not exist at that time (if I understand correctly),
> so if grep prints something to stderr - it will create a /dev/null file
> (not sure if it is an issue though).

Well ... this is a corner-case, but it might not exist (in a common
setup, it will exist). I'll fix that - we don't really need the
2>/dev/null anyway.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/arch-dev-public/attachments/20100604/76f8005e/attachment.bin>