[arch-dev-public] [PATCH] Do not refer to $startdir/{src, pkg} in PKGBUILDs
Allan McRae
allan at archlinux.org
Tue Jun 8 03:43:47 EDT 2010
On 08/06/10 17:28, Pierre Schmitz wrote:
> On Tue, 8 Jun 2010 13:18:17 +1000, Allan McRae<allan at archlinux.org>
> wrote:
>> PKGBUILDs should always use $srcdir and $pkgdir and their locations
>> are not guaranteed to be $startdir/src and $startdir/pkg respecitively.
>>
>> Signed-off-by: Allan McRae<allan at archlinux.org>
>
> When will $startdir be removed? I just checked: 1022 packages are
> affected. (not a big deal though as they can changed on rebuilds)
>
> But I have seen packages which modify the .install script during build.
> For example to set the current kernel version for depmod. How could this be
> handled then? Or are .install scripts are now available under srcdir?
>
$startdir will not be removed. The error printed for $startdir usage
was always there so I did not change that. For install files, once 3.4
is released, you can put them in the source array without any issues and
then adjust them in $srcdir.
This patch was mainly to check for $startdir/pkg which will not be the
same as $pkgdir from 3.5 onwards (i.e. two releases away). This is
already true for split packages, but will become true for unsplit ones
too. A lot of packages are affected but we have been telling people
not to use $startdir/pkg for more that a year, maybe even two years...
Allan
More information about the arch-dev-public
mailing list