[arch-dev-public] [RFC] Initialize /etc/mtab by copying /proc/mounts

[Dan McGee]

On Tue, Jun 8, 2010 at 5:48 PM, Thomas Bächler <thomas at archlinux.org> wrote:
> Our current process of initializing /etc/mtab is
> hackish and probably error-prone, replace it by
> simply copying /proc/mounts.
> ---

Looks good to me (but untested). This goes way back to the roots of Arch, wow.

>  rc.sysinit |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/rc.sysinit b/rc.sysinit
> index 8349860..b78d3e7 100755
> --- a/rc.sysinit
> +++ b/rc.sysinit
> @@ -295,13 +295,7 @@ fi
>
>  stat_busy "Mounting Local Filesystems"
>  /bin/mount -n -o remount,rw /
> -: >| /etc/mtab
> -# make sure / gets written to /etc/mtab
> -/bin/mount -o remount,rw /
> -# Write /proc, /sys and /dev to /etc/mtab
> -if [ -e /proc/mounts ]; then
> -       /bin/grep -e "/proc " -e "/sys " -e "/dev " /proc/mounts >> /etc/mtab
> -fi
> +cat /proc/mounts >| /etc/mtab
>  run_hook sysinit_premount
>  # now mount all the local filesystems
>  /bin/mount -a -t $NETFS -O no_netdev
> --
> 1.7.1
>
>