[arch-dev-public] [PATCH 1/4] Handle error case of parsepkgbuild correctly

[Allan McRae]

On 15/06/10 15:29, Dan McGee wrote:
> We were never checking the return code of parsepkgbuild so would try to
> parse the error message it printed out as a package definition rather than
> erroring and returning None. Look at the return code, and as a bonus, use
> the more correct communicate() rather than stdout.read().
>
> Signed-off-by: Dan McGee<dan at archlinux.org>

Something is changed here...  After applying this commit:

 > PATH=$(pwd):$PATH
 > PYTHONPATH=$(pwd)
 > for i in /var/abs/core/*; do ./namcap -t namcap-tags $i/PKGBUILD; done
Error: /var/abs/core/acl/PKGBUILD is not a valid PKGBUILD
Error: /var/abs/core/ar9170-fw/PKGBUILD is not a valid PKGBUILD
Error: /var/abs/core/attr/PKGBUILD is not a valid PKGBUILD
Error: /var/abs/core/b43-fwcutter/PKGBUILD is not a valid PKGBUILD
PKGBUILD: line 27: seq: command not found
PKGBUILD (bash) E: Too many md5sums: 5 needed
Error: /var/abs/core/bin86/PKGBUILD is not a valid PKGBUILD
Error: /var/abs/core/bridge-utils/PKGBUILD is not a valid PKGBUILD
Error: /var/abs/core/bzip2/PKGBUILD is not a valid PKGBUILD
...
PKGBUILD (db) W: Description should not contain the package name.
...
PKGBUILD (filesystem) W: Description should not contain the package name.


As you can see, some PKGBUILD appear to work... although I have no idea why.

Allan