[arch-dev-public] [PATCH] parsepkgbuild: don't let test [ return codes leak

Allan McRae allan at archlinux.org
Tue Jun 15 23:46:12 EDT 2010


On 16/06/10 01:14, Dan McGee wrote:
> when using `[ ]&&  action` style tests, the return code of the test can
> leak, which was unfortuante for every PKGBUILD that didn't contain an
> install file as the last test would always return 1 (failure). We want
> parsepkgbuild to return 0 if we make it all the way through.
>
> "Fix" all of the shortcut test forms to just use the full `if [ ]; then`
> block instead of a shortcut.
>
> Signed-off-by: Dan McGee<dan at archlinux.org>
> ---

Great.  After applying all the patches sent to this list, the only 
problems I have scanning all the packages and PKGBUILDs from [core] is 
the bash and readline PKGBUILDs which have a non-bash way of generating 
the source array.

Signoff all,
Allan


More information about the arch-dev-public mailing list