[arch-dev-public] [PATCH] [makechrootpkg] Fixed changelog support to work with makepkg 3.4

Pierre Schmitz pierre at archlinux.de
Mon Jun 28 02:21:52 EDT 2010


On Mon, 28 Jun 2010 16:18:14 +1000, "Allan McRae" <allan at archlinux.org>
wrote:
> On 28/06/10 16:07, Pierre Schmitz wrote:
>> I will apply this for now as we handle the install files the same way.
>> In future we should come up with a better solution though. It's quite
>> easy to write a PKGBUILD where this method will fail. The propper way is
>> to source the PKGBUILD and use the evaluated $changelog variable.
>>
>> A problem are the package functions; I don't see a way to call them
>> without executing the make install or whatever commands. (I'll better
>> open a new thread about this problem)
>>
> 
> You can probably follow makepkg's handling in the source package
> creation.  See makepkg lines 1110-1122.

That is more clean indeed. But this will also fail if you enclose the
changelog,install definition in an if-statement for example. :-) But I
guess there wont be a super solid solution by design.

-- 
Pierre Schmitz, https://users.archlinux.de/~pierre


More information about the arch-dev-public mailing list