[arch-dev-public] [PATCH 2/3] Use endswith rather than arbitrary array lengths

Dan McGee dan at archlinux.org
Sun Feb 27 12:25:40 EST 2011


A lot clearer and not magical.

Signed-off-by: Dan McGee <dan at archlinux.org>
---
 namcap.py |    2 +-
 pacman.py |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/namcap.py b/namcap.py
index 44440a9..8f69f74 100755
--- a/namcap.py
+++ b/namcap.py
@@ -272,7 +272,7 @@ for package in packages:
 
 	if os.path.isfile(package) and tarfile.is_tarfile(package):
 		process_realpackage(package, active_modules)
-	elif package[-8:] == 'PKGBUILD':
+	elif package.endswith('PKGBUILD'):
 		process_pkgbuild(package, active_modules)
 	else:
 		print("Error: Cannot process %s" % package)
diff --git a/pacman.py b/pacman.py
index 9473f6e..db45539 100644
--- a/pacman.py
+++ b/pacman.py
@@ -47,7 +47,7 @@ def load(package, root=None):
 		return ret
 
 	# Ooooo, it's a PKGBUILD
-	elif package[-8:] == 'PKGBUILD':
+	elif package.endswith('PKGBUILD'):
 		# Load all the data like we normally would
 		workingdir = os.path.dirname(package)
 		if workingdir == '':
-- 
1.7.4.1



More information about the arch-dev-public mailing list