[arch-dev-public] [PATCH 2/2] Upload package signature file if available

Dan McGee dpmcgee at gmail.com
Wed Mar 16 21:05:59 EDT 2011


On Sat, Mar 12, 2011 at 9:24 PM, Allan McRae <allan at archlinux.org> wrote:
> Signed-off-by: Allan McRae <allan at archlinux.org>
> ---
>  commitpkg |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/commitpkg b/commitpkg
> index 390f99e..5bf8d65 100755
> --- a/commitpkg
> +++ b/commitpkg
> @@ -117,9 +117,16 @@ for _arch in ${arch[@]}; do
>                        echo "skipping ${_arch}"
>                        continue 2
>                fi
> +
> +               if [ ! -f "$pkgfile.sig" ]; then
> +                       echo "WARNING: No package signature found"
> +               fi
>
>                echo -n 'uploading '
>                rsync -p --chmod 'ug=rw,o=r' -c -h -L --progress $rsyncopts --partial "${pkgfile}" -e ssh "$server:staging/$repo/${pkgfile##*/}" || abort
> +               if [ -f "$pkgfile.sig" ]; then
> +                       rsync -p --chmod 'ug=rw,o=r' -c -h -L --progress $rsyncopts --partial "${pkgfile}.sig" -e ssh "$server:staging/$repo/${pkgfile##*/}.sig" || abort
> +               fi
This is silly- rsync can take multiple SRC arguments (and why aren't
our args all at the end?).

rsync ... ${pkgfile} ${sigfile} ....

and define sigfile to the empty string or the sigfile filename above
depending on whether it exists.

>        done
>        archrelease $repo-${_arch} || abort
>  done
> --
> 1.7.4.1
>
>


More information about the arch-dev-public mailing list