[arch-dev-public] [arch-commits] Commit in procps-ng/trunk (PKGBUILD sysctl.conf)

[Eric Bélanger]

On Wed, Jul 11, 2012 at 8:20 AM, Dan McGee <dan at archlinux.org> wrote:
> On Tue, Jul 10, 2012 at 11:08 PM, Eric Bélanger <eric at archlinux.org> wrote:
>>     Date: Wednesday, July 11, 2012 @ 00:08:20
>>   Author: eric
>> Revision: 163220
>>
>> upgpkg: procps-ng 3.3.3-2
>>
>> Enable IPv6 privacy extensions in sysctl.conf (close FS#30278)
>> Modified:
>>   procps-ng/trunk/PKGBUILD
>>   procps-ng/trunk/sysctl.conf
>>
>> -------------+
>>  PKGBUILD    |    4 ++--
>>  sysctl.conf |    5 +++++
>>  2 files changed, 7 insertions(+), 2 deletions(-)
>>
>> Modified: PKGBUILD
>> ===================================================================
>> --- PKGBUILD    2012-07-11 01:43:03 UTC (rev 163219)
>> +++ PKGBUILD    2012-07-11 04:08:20 UTC (rev 163220)
>> @@ -3,7 +3,7 @@
>>
>>  pkgname=procps-ng
>>  pkgver=3.3.3
>> -pkgrel=1
>> +pkgrel=2
>>  pkgdesc="Utilities for monitoring your system and processes on your system"
>>  arch=('i686' 'x86_64')
>>  url="http://gitorious.org/procps"
>> @@ -18,7 +18,7 @@
>>  source=(procps-ng-${pkgver}.tar.gz::http://gitorious.org/procps/procps/archive-tarball/v${pkgver}
>>          sysctl.conf)
>>  sha1sums=('e78a098f1a3c06722155800cc5cfa0c865af03c0'
>> -          'ddf0dab2e3612d44903fc02f46316cabbec4651e')
>> +          '46215e54fbca366cecd81ac47bc1997f147be462')
>>
>>  build() {
>>    cd "${srcdir}/procps-procps"
>>
>> Modified: sysctl.conf
>> ===================================================================
>> --- sysctl.conf 2012-07-11 01:43:03 UTC (rev 163219)
>> +++ sysctl.conf 2012-07-11 04:08:20 UTC (rev 163220)
>> @@ -22,6 +22,11 @@
>>  net.ipv4.ip_forward = 0
>>  net.ipv6.conf.all.forwarding = 0
>>
>> +# Enable IPv6 Privacy Extensions
>> +net.ipv6.conf.default.use_tempaddr = 2
>> +net.ipv6.conf.all.use_tempaddr = 2
>> +net.ipv6.conf.eth0.use_tempaddr = 2
>
> What is eth0 doing in a enabled sysctl template setting? There is no
> guarantee everyone even has an eth0 or has it enabled, so this
> shouldn't be in here.
>
> NACK on the package until this is fixed.
>

OK. I'll remove it.

>> +
>>  # sets the port range used for outgoing connections
>>  #net.ipv4.ip_local_port_range = 32768    61000
>>
>>