[arch-dev-public] pacman-4.1

[Allan McRae]

On 05/04/13 19:09, Thomas Bächler wrote:
> Am 05.04.2013 10:57, schrieb Allan McRae:
>> On 05/04/13 18:34, Thomas Bächler wrote:
>>> Am 01.04.2013 08:39, schrieb Allan McRae:
>>>> Hi,
>>>>
>>>> Pacman-4.1.0 is released and in the [testing] repos.  See my blog [1]
>>>> for details of what is new in this release.
>>>>
>>>> Cheers,
>>>> Allan
>>>>
>>>>
>>>> [1] http://allanmcrae.com/2013/04/pacman-4-1-released/
>>>
>>> The new default CPPFLAGS seem to break configure. cpp complains that
>>> -D_FORTIFY_SOURCE=2 cannot be used without -O.
>>>
>>
>> I thought it fixed issues (e.g. curl).
>>
>> Or are we both just taking one package and wildly generalising...?
> 
> We are. This is what I got:
> 
> 
> configure:6470: checking how to run the C preprocessor
> configure:6501: gcc -E -D_FORTIFY_SOURCE=2 conftest.c
> In file included from /usr/include/limits.h:26:0,
>                  from
> /usr/lib/gcc/x86_64-unknown-linux-gnu/4.8.0/include-fixed/limits.h:168,
>                  from
> /usr/lib/gcc/x86_64-unknown-linux-gnu/4.8.0/include-fixed/syslimits.h:7,
>                  from
> /usr/lib/gcc/x86_64-unknown-linux-gnu/4.8.0/include-fixed/limits.h:34,
>                  from conftest.c:13:
> /usr/include/features.h:330:4: warning: #warning _FORTIFY_SOURCE
> requires compiling with optimization (-O) [-Wcpp]
>  #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
>     ^
> configure:6501: $? = 0
> configure: failed program was:
> | /* confdefs.h */
> | #define PACKAGE_NAME "shellinabox"
> | #define PACKAGE_TARNAME "shellinabox"
> | #define PACKAGE_VERSION "2.10"
> | #define PACKAGE_STRING "shellinabox 2.10"
> | #define PACKAGE_BUGREPORT "markus at shellinabox.com"
> | #define PACKAGE_URL ""
> | #define VCS_REVISION "239"
> | #define PACKAGE "shellinabox"
> | #define VERSION "2.10"
> | /* end confdefs.h.  */
> | #ifdef __STDC__
> | # include <limits.h>
> | #else
> | # include <assert.h>
> | #endif
> |                    Syntax error
> 
> Confusing here is that there is no error, just a warning, but it still
> starts retrying different preprocessor command and eventually fails.
> Appending -O2 to the CPPFLAGS fixed the build.
> 

Yes...  this is my pet hate - people who use -Werror and expect their
code to be magically immune to any future warnings.  And this is even
more annoying because it is quite hidden...

Fix:

sed "s#AC_LANG_WERROR##" configure.ac
autoreconf -i

Allan