[arch-general] [PATCH] devtools: make sure all files are owned by nobody before building

Nezmer Nezmer at allurelinux.org
Sun Dec 27 05:42:11 EST 2009


In makechrootpkg, build dirs are chowned to nobody before we move files
to "$uniondir/build". This could lead to failure If the files are
supposed to be dynamically upgraded when we run makepkg.

A common use-case is when we upgrade $pkgver in git,svn PKGBUILDS.

Signed-off-by: Nezmer <Nezmer at allurelinux.org>
---
 makechrootpkg |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/makechrootpkg b/makechrootpkg
index 1d2282c..88d52ef 100755
--- a/makechrootpkg
+++ b/makechrootpkg
@@ -166,10 +166,6 @@ if ! grep "SRCDEST=/srcdest" "$uniondir/etc/makepkg.conf" >/dev/null 2>&1; then
     echo "SRCDEST=/srcdest" >> "$uniondir/etc/makepkg.conf"
 fi
 
-chown -R nobody "$uniondir/build"
-chown -R nobody "$uniondir/srcdest"
-chown -R nobody "$uniondir/pkgdest"
-
 # Copy PKGBUILD and sources
 source PKGBUILD
 cp PKGBUILD "$uniondir/build/"
@@ -200,6 +196,10 @@ if [ -f "ChangeLog" ]; then
     cp ChangeLog "$uniondir/build/"
 fi
 
+chown -R nobody "$uniondir/build"
+chown -R nobody "$uniondir/srcdest"
+chown -R nobody "$uniondir/pkgdest"
+
 if ! grep "^nobody" "$uniondir/etc/sudoers" >/dev/null 2>&1; then
     echo "allowing 'nobody' sudo rights in the chroot"
     touch "$uniondir/etc/sudoers"
-- 
1.6.6



More information about the arch-general mailing list