[arch-general] [RFC] patches to initscripts

[Thomas Bächler]

Am 06.12.2010 16:48, schrieb Tom Gundersen:
> On Mon, Dec 6, 2010 at 1:52 PM, Thomas Bächler <thomas at archlinux.org> wrote:
>> Thanks. The initscripts patch won't work though:
>>
>> [[ $USELVM =~ yes|YES && -x /sbin/lvm && -d /sys/block ]] || return
>> "return" is a statement that will only work inside a function. I don't
>> know what it will do on the top level, but certainly not what you'd expect.
> 
> D'oh! Copy-paste error, sorry about that.
> 
> Updated commit:
> <https://github.com/teg/initscripts-arch/commit/feef447b8368244525dd98582b662a369098b2f7>.
> 
> Thanks for testing,
> 
> Tom
> 

I pushed everything to the official git tree.

There's one more thing about the check in the SWAP area of the crypttab
code: Instead of using isLuks to check for a LUKS device, check with
blkid whether there is any valid file system signature on it.

The problem is: If blkid finds more than one valid signature, it will
not return anything, and we will mistakenly believe that there is no
file system (and happily overwrite the drive). This part of initscripts
is giving me a headache everytime I touch it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/arch-general/attachments/20101207/3a8b181b/attachment-0001.bin>