[arch-general] [arch-dev-public] Let's agree on a common coding style

Evangelos Foutras foutrelis at gmail.com
Sat Feb 13 16:22:00 EST 2010


On 13/02/2010 11:11 μμ, Thomas Bächler wrote:
> Am 13.02.2010 21:57, schrieb Dieter Plaetinck:
>>>> For example, in a PKGBUILD I would write ${pkgname}_$pkgver,
>>>> because _ can be part of a variable name, but I'd much rather
>>>> prefer to use $pkgname-$pkgver, since hyphens are not allowed in
>>>> variable names.
>>>>
>>>> Less typing, less ugliness. :)
>>>>
>>>
>>> This is the way I've always done it and it's much nicer to read. Same
>>> for quoting, use only when needed.
>>
>> +1 for braces around vars only when needed.
>
> If you use braces only when necessary, it will not be consistent - you
> have braces sometimes and other times you don't. I thought coding style
> was about consistency.

As Dieter mentioned, we can use braces when needed and be consistent in 
this regard. Most of the time they are not needed and I think using them 
everywhere hinders readability with no obvious benefit.


More information about the arch-general mailing list