[arch-general] [PATCH 01/48] Bashification of initscripts

[Thomas Bächler]

Am 11.07.2010 15:12, schrieb Victor Lowther:
> On Sun, 2010-07-11 at 14:26 +0200, Thomas Bächler wrote:
>> Am 11.07.2010 14:20, schrieb Victor Lowther:
>>> Going back through and rewriting the patch series to do that will be
>>> jsut about as much effort as creating the original one was.  If I had
>>> know that was what your preference was, I would have written it that
>>> way to begin with.  Since the end result is going to be the same once
>>> the patch series is applied, though, I don't really see the point of
>>> making modifications beyond bugfixes.
>>
>> It is a matter of keeping the history readable. And it is simple: Just
>> create a new branch based on master, cherry-pick the commits that do
>> nothing but change [ to [[ and git merge --squash that branch into a new
>> one.
> 
> If that is all you wnat done, that is easy enough to do.  If you want
> all of the instances of trivial bashification split out from where I
> reworked the logic in the same patch, that is much less easy.

No no, that wouldn't make sense. It should be this way: First all
patches that actually change logic, then one big commit that just
converts the _remaining_ [ to [[ with no additional logic changes involved.


I hope to actually finish the review of the rest of the patches some
time this week, sorry that I let so much time pass now.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/arch-general/attachments/20100711/3f574004/attachment-0001.bin>