[arch-general] [PATCH 12/48] Replace slightly too long echo staement with a here document.

Victor Lowther victor.lowther at gmail.com
Wed Jun 30 17:47:43 EDT 2010


This adds a line, but making things more readable is worth it.
---
 functions |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/functions b/functions
index 56c6a7b..9730150 100644
--- a/functions
+++ b/functions
@@ -265,12 +265,13 @@ set_consolefont() {
 	/usr/bin/setfont ${CONSOLEMAP:+-m ${CONSOLEMAP}} \
 	    $CONSOLEFONT -C ${i} >/dev/null 2>&1
     done
-    if [ $? -ne 0 ]; then
+    if (($? != 0)); then
 	stat_fail
-    else
-	if [ -n "$CONSOLEMAP" ]; then
-	    echo 'if [ "$CONSOLE" = "" -a "$TERM" = "linux" -a -t 1 ]; then printf "\033(K"; fi' >>/etc/profile.d/locale.sh
-	fi
+    elif [[ $CONSOLEMAP ]]; then
+	cat <<"EOF" >>/etc/profile.d/locale.sh
+if [ "$CONSOLE" = "" -a "$TERM" = "linux" -a -t 1 ]; then printf "\033(K"; fi
+
+EOF
 	stat_done
     fi
 }
-- 
1.7.1



More information about the arch-general mailing list