[arch-general] [PATCH 01/48] Bashification of initscripts

[Thomas Bächler]

Am 01.07.2010 00:07, schrieb Victor Lowther:
> On Wed, 2010-06-30 at 23:55 +0200, Thomas Bächler wrote:
>> Am 30.06.2010 23:47, schrieb Victor Lowther:
>>> Despite efforts to make the initscripts POSIX, we use bash 4.0 features.
>>>
>>> Bashifying this framework should result in about a 30% speedup, assuming no
>>> IO latency and that all programs we call also take zero time. :)
>>> ---
>>>  functions |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/functions b/functions
>>> index 672eed2..023de35 100644
>>> --- a/functions
>>> +++ b/functions
>>> @@ -1,4 +1,4 @@
>>> -#
>>> +#!/bin/bash
>>>  # initscripts functions
>>
>> I don't see the need for this patch. functions is not supposed to be
>> executed standalone, it is only source'd from bash scripts.
> 
> It is a habit I have -- including the shebang line at the top makes sure
> my text editors automatically detect the right shell syntax for syntax
> highlighting.
> 

Fair enough, but then that should be in the commit message.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/arch-general/attachments/20100701/967bd8b4/attachment.bin>