[arch-general] [PATCH 1/2] kill_everything: Reduce number of -f tests

[Thomas Bächler]

Am 08.09.2010 06:16, schrieb Victor Lowther:
> On Tue, Sep 7, 2010 at 10:47 PM, Dave Reisner <d at falconindy.com> wrote:
>> Instead of checking for the existance of a file in /var/run/daemons on
>> every iteration, handle the null case by setting nullglob. The shopt
>> call is done inside a subshell as to not bother the environment since we
>> may be going to runlevel 1 only temporarily.
> 
> I thought about just enabling nullglobs and extglobs unconditionally
> in functions, but decided that was too likely to get objections no
> matter how unlikely breakage was. :)

As for nullglob, I do think it is useful and enabling it might be useful
in so many places - I didn't even know this option, it would have been
useful for me before. I am in favor of enabling nullglob in function and
dropping that subshell.

Do we need extglob anywhere? I don't think so.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/arch-general/attachments/20100908/db9c18e6/attachment.bin>