[arch-general] makechrootpkg and multiple sources, a bug?

[Magnus Therning]

I just tried building a package with more than one source file using
makechrootpkg.  It failed with this message:

  ==> ERROR: Integrity checks (md5) differ in size from the source array.

After a bit of poking around in the makechrootpkg script I made the
following change:

--- makechrootpkg.orig  2011-02-20 09:22:30.130744179 +0000
+++ makechrootpkg       2011-02-20 09:22:44.494796349 +0000
@@ -173,7 +173,7 @@
 for f in ${source[@]}; do
        basef=$(echo $f | sed 's|::.*||' | sed 's|^.*://.*/||g')
        if [ -f "$basef" ]; then
-               cp "$basef" "$copydir/srcdest/"
+               cp "$basef" "$copydir/build/"
        elif [ -f "$SRCDEST/$basef" ]; then
                cp "$SRCDEST/$basef" "$copydir/srcdest/"
        fi

After this the package built just fine.  I'm doubting myself in this
though, because it seems like such an obvious bug, especially since
the PKGBUILD is copied into $copydir/build/ just a few lines above
this change.  Also, should the copy in the elif-branch be changed too?

/M

-- 
Magnus Therning                      OpenPGP: 0xAB4DFBA4 
email: magnus at therning.org   jabber: magnus at therning.org
twitter: magthe               http://therning.org/magnus

I invented the term Object-Oriented, and I can tell you I did not have
C++ in mind.
     -- Alan Kay
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://mailman.archlinux.org/pipermail/arch-general/attachments/20110220/7b6085a5/attachment.asc>