[arch-projects] Patch for version strings
tardo at nagi-fanboi.net
Sun Sep 30 21:10:51 EDT 2007
> On 9/30/07, Paul Mattal <paul at mattal.com> wrote:
>> tardo at nagi-fanboi.net wrote:
>>>> Here's a bug: pages other than index.php show $Id$ instead of Version:
>>>> Category and Name are squashed together (table header in
>>>> packages.php). Same for Votes Voted Description
>>> Fix version strings.
>>> Now you should only have to change AUR_VERSION in web/lib/config.inc and
>>> updates will be reflected across the site. KISS ftw.
>> The problem with this fix is that config.inc is intentionally NOT
>> upgraded when we upgrade code, so it will fall to the user to have to
>> remember to upgrade the version string which is exactly what we don't want.
>> So maybe we could put the define in aur.inc instead, or someplace else
>> that always gets included? I think aur.inc is always included.
>> - P
> How about we make a one time change to config.inc to include
> version.inc at the top.
> Then have a new file (version.inc) with nothing more than a define for
> the version variable.
> aur.inc is messy enough. I would hate to start getting more random
> defines in there.
> arch-projects mailing list
> arch-projects at archlinux.org
I'm not against either idea, but if a user checks out a copy of AUR and
modifies then uses it, it should be his responsibility to change (or
remove) the version number. Adding a version.inc still requires the user
to modify it himself, and config.inc is ignored by git anyway, so it
shouldn't affect the development process (i.e. only Paul should have to
worry about changing the version number on the real AUR site).
Either way, if you come to a consensus, a patch is easy to write for either.
More information about the arch-projects