[arch-projects] [devtools] [PATCH 1/3] commitpkg: Proper quoting in version control checks

Lukas Fleischer archlinux at cryptocrack.de
Wed Aug 10 09:17:58 EDT 2011


Signed-off-by: Lukas Fleischer <archlinux at cryptocrack.de>
---
 commitpkg |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/commitpkg b/commitpkg
index 9856df1..999c35f 100755
--- a/commitpkg
+++ b/commitpkg
@@ -78,9 +78,9 @@ case "$repo" in
 esac
 
 # check if all local source files are under version control
-for s in ${source[@]}; do
-	echo $s | grep -Fvq '://' && \
-	svn status $s | grep -q '^\?' && \
+for s in "${source[@]}"; do
+	echo "$s" | grep -Fvq '://' && \
+	svn status "$s" | grep -q '^\?' && \
 	abort "$s is not under version control"
 done
 
@@ -90,7 +90,7 @@ for i in 'changelog' 'install'; do
 	for file in $filelist; do
 		# evaluate any bash variables used
 		eval file=${file}
-		if svn status ${file} | grep -q '^\?'; then
+		if svn status "${file}" | grep -q '^\?'; then
 			abort "${file} is not under version control"
 		fi
 	done
-- 
1.7.6



More information about the arch-projects mailing list