[arch-projects] [devtools][PATCH 3/6] commitpkg: use all remaining args as the commit msg

[Lukas Fleischer]

On Tue, Aug 16, 2011 at 09:35:58PM -0400, Dave Reisner wrote:
> From: Dave Reisner <d at falconindy.com>
> 
> Signed-off-by: Dave Reisner <d at falconindy.com>
> ---
> Small pet peeve of mine. I always expect -m to be required for a commit msg. I
> have a startling number of commits where the message is only -m. We should at
> least use _all_ the arguments so that the next time a noodle noggin such as
> myself insists on using the unneeded -m, we get a useful commit msg along with
> the "mark of shame".
> 
>  commitpkg |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/commitpkg b/commitpkg
> index 1275615..01c09d5 100755
> --- a/commitpkg
> +++ b/commitpkg
> @@ -114,7 +114,7 @@ if [ -n "$(svn status -q)" ]; then
>  	echo -n 'committing changes to trunk...'
>  	msgtemplate="upgpkg: $pkgbase $(get_full_version ${epoch:-0} $pkgver $pkgrel)"$'\n\n'
>  	if [ -n "$1" ]; then
> -		svn commit -q -m "${msgtemplate}${1}" || abort
> +		svn commit -q -m "${msgtemplate}$*" || abort

-1. The second patch already fixes this:

----
$ communitypkg -m 'Anything that happens, happens.'
invalid option -- 'm'
----

Also, I'd rather say we should check if there's more than one additional
argument in the commitpkg invocation and bail out if there is.

>  	else
>  		msgfile="$(mktemp)"
>  		echo "$msgtemplate" > "$msgfile"
> -- 
> 1.7.6