[arch-projects] [initscripts] [PATCH 11/20] Deprecate in_array()
teg at jklm.no
Sun Jul 10 16:09:06 EDT 2011
On Sun, Jul 10, 2011 at 7:26 PM, Kurt J. Bosch
<kjb-temp-2009 at alpenjodel.de> wrote:
> in_array() strips '@' and therefore the name is missleading.
> For checking DAEMONS, ck_autostart() should be used.
Here you introduce a change not mentioned in the commit message:
in_array is used to check for forcefsck, so this patch does this
inline instead (which makes me more hesitant than before to apply it).
Changing in_array to ck_autostart would be fine, but I don't see the
benefit of deprecating in_array. If in_array() has a bug, then we
should fix it, if this causes regressions then they should be fixed,
if they cannot be fixed we might consider adding a new is_in_array and
deprecating the old one. However, I'd rather not derpecate/change/add
functions unless we must.
If there are bugs out there that I'm not aware of, and that would be
fixed by this patch, please let me know.
More information about the arch-projects