[arch-projects] [PATCH 1/2] Ensure all variables are unset before loading profile

[Dan McGee]

On Mon, Jun 20, 2011 at 1:06 AM, Rémy Oudompheng
<remyoudompheng at gmail.com> wrote:
> On 2011/6/20 Dan McGee <dan at archlinux.org> wrote:
>> This sucks a bit, but is a big failing of netcfg I found when writing my next
>> patch. It screams "there must be a better way", but at the moment I'm not sure
>> what that may be. The biggest problem is there is no central collection of
>> these variables which I had to scrape from the various setup scripts. Thoughts?
>
> I'd better say we should enforce the use of subshells whenever
> multiple profiles are expected to be loaded in a sequence.
Of course now it appears all calls are in subshells; this was old
work, I'm not sure if something changed in the last 4 months I've had
this sitting around but I swear I had a reproducible test case at the
time.

> For
> example; by making load_profile a hard failure if $DESCRIPTION (or any
> other common variable) is already set.
$CONNECTION is probably your best variable choice here.

-Dan