[arch-projects] [initscripts] [PATCH 08/13] Simplify unmounting filesystems

[Kurt J. Bosch]

Tom Gundersen, 2011-06-24 11:44:
> On Fri, Jun 24, 2011 at 11:14 AM, Kurt J. Bosch
> <kjb-temp-2009 at alpenjodel.de>  wrote:
>> This also keeps all tmpfs allways. Some might be in still in use because of a running splash daemon etc.
>> ---
>>   rc.shutdown |    6 +-----
>>   1 files changed, 1 insertions(+), 5 deletions(-)
>>
>> diff --git a/rc.shutdown b/rc.shutdown
>> index 2d23554..39adaad 100755
>> --- a/rc.shutdown
>> +++ b/rc.shutdown
>> @@ -52,12 +52,8 @@ if [[ $USELVM = [Yy][Ee][Ss]&&  -x $(type -P lvm)&&  -d /sys/block ]]; then
>>   fi
>>
>>   stat_busy "Unmounting Filesystems"
>> -if grep -q devtmpfs /proc/filesystems&>/dev/null; then
>> -       umount -a -r -t nosysfs,noproc,nodevtmpfs,nodevpts -O no_netdev
>> -else
>>         # if we don't have devtmpfs support, /dev is mounted as tmpfs, so don't unmount it
>> -       umount -a -r -t notmpfs,nosysfs,noproc,nodevpts -O no_netdev
>> -fi
>> +       umount -a -r -t nodevtmpfs,notmpfs,nosysfs,noproc,nodevpts -O no_netdev
>>   stat_done
>>
>>   run_hook shutdown_postumount
>> --
> In principle I agree (especially due to /run), but the reason we had
> this code was that in case someone has a tmpfs mounted on top of a
> blockdevice. This means that we need to unmount that tmpfs before we
> can unmount the blockdevice.
>
> Maybe what we need is the inverse of what is done at the beginning of
> rc.sysinit. I.e., unmount all filesystems, regardless of type, except
> the ones we explicitly mounted at early boot.
>
> What do you think?
Disks will be remounted read-only if unmount failes. I guess that should 
be save enough as it happens to the root-FS anyways because  /dev isn't 
unmounted.
--
Kurt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.archlinux.org/pipermail/arch-projects/attachments/20110624/94c09640/attachment.html>