[arch-projects] [initscripts] [PATCH] Setting Locale: fix status reporting FAIL erroneously

[Kurt J. Bosch]

Dave Reisner, 2011-06-25 16:27:
> On Sat, Jun 25, 2011 at 03:38:52PM +0200, Kurt J. Bosch wrote:
>> Dave Reisner, 2011-06-25 15:27:
>>> On Sat, Jun 25, 2011 at 03:17:40PM +0200, Kurt J. Bosch wrote:
>>>> From: "Kurt J. Bosch"<kjb-temp-2009 at alpenjodel.de>
>>>>
>>>> ---
>>>>   rc.sysinit |    2 +-
>>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/rc.sysinit b/rc.sysinit
>>>> index 4073fb9..75f8095 100755
>>>> --- a/rc.sysinit
>>>> +++ b/rc.sysinit
>>>> @@ -229,7 +229,7 @@ stat_done
>>>>
>>>>   # Flush old locale settings and set user defined locale
>>>>   status "Setting Locale: ${LOCALE:=en_US}" \
>>>> -	install -Tm 0755<(echo "export LANG=$LOCALE") /etc/profile.d/locale.sh
>>>> +	eval 'install -Tm 0755<(echo "export LANG=$LOCALE") /etc/profile.d/locale.sh'
>>>>
>>>>   if [[ ${LOCALE,,} =~ utf ]]; then
>>>>   	stat_busy "Setting Consoles to UTF-8 mode"
>>>> --
>>>> 1.7.5.2
>>>>
>>>
>>> NACK.
>>>
>>> As far as I can tell, the eval is not at all necessary.
>>>
>>> dave
>>>
>> Yes, that's a bit strange. When trying in a terminal it works
>> without, but when actually booting it doesn't. Maybe some BASH bug?
>> --
>> Kurt
>
> Works for me. More likely, the problem is the missing whitespace between
> 0755 and the process substitution. No idea why the eval 'fixes' that,
> though.

Actually the whitespace *is* there, it just disappeared in this thread.
>
> I wouldn't be too keen on cleaning up the locale stuff anyways -- it
> needs a proper fix. Setting the locale as part of an /etc/profile.d is
> the wrong thing to do.
>
> d

So maybe this code should be dropped and locale.sh or some other config 
file should be set up manually?
This way rc.conf would only be responsible for things affecting sysinit 
and daemons, but we would also need something to get rid of the 
CONSOLEMAP hack in set_consolefont().

--
Kurt