[arch-projects] [ABS] [PATCH 1/6] vcs prototypes: remove build directories after making package

[Dave Reisner]

On Wed, Nov 02, 2011 at 05:49:27PM -0700, Linus Arver wrote:
> For all vcs prototypes, we currently create a temporary build directory.
> However, we do not delete it after we are done creating the package.
> This wastes disk space.
> 
> We already do a "rm -rf" on the build directories every time after we do
> a checkout anyway, so this patch doesn't really change anything.
> 

Big -1 from me. This prevents repackaging.

dave

> Signed-off-by: Linus Arver <linusarver at gmail.com>
> ---
>  prototypes/PKGBUILD-bzr.proto   |    2 ++
>  prototypes/PKGBUILD-cvs.proto   |    2 ++
>  prototypes/PKGBUILD-darcs.proto |    2 ++
>  prototypes/PKGBUILD-git.proto   |    2 ++
>  prototypes/PKGBUILD-hg.proto    |    2 ++
>  prototypes/PKGBUILD-svn.proto   |    2 ++
>  6 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/prototypes/PKGBUILD-bzr.proto b/prototypes/PKGBUILD-bzr.proto
> index 81f145f..fca5f36 100644
> --- a/prototypes/PKGBUILD-bzr.proto
> +++ b/prototypes/PKGBUILD-bzr.proto
> @@ -59,6 +59,8 @@ build() {
>  package() {
>    cd "$srcdir/$_bzrmod-build"
>    make DESTDIR="$pkgdir/" install
> +
> +  rm -rf "$srcdir/$_bzrmod-build"
>  }
>  
>  # vim:set ts=2 sw=2 et:
> diff --git a/prototypes/PKGBUILD-cvs.proto b/prototypes/PKGBUILD-cvs.proto
> index 982c149..997373d 100644
> --- a/prototypes/PKGBUILD-cvs.proto
> +++ b/prototypes/PKGBUILD-cvs.proto
> @@ -60,6 +60,8 @@ build() {
>  package() {
>    cd "$srcdir/$_cvsmod-build"
>    make DESTDIR="$pkgdir/" install
> +
> +  rm -rf "$srcdir/$_cvsmod-build"
>  }
>  
>  # vim:set ts=2 sw=2 et:
> diff --git a/prototypes/PKGBUILD-darcs.proto b/prototypes/PKGBUILD-darcs.proto
> index 979e9b5..cbeef29 100644
> --- a/prototypes/PKGBUILD-darcs.proto
> +++ b/prototypes/PKGBUILD-darcs.proto
> @@ -61,6 +61,8 @@ build() {
>  package() {
>    cd "$srcdir/$_darcsmod-build"
>    make DESTDIR="$pkgdir/" install
> +
> +  rm -rf "$srcdir/$_darcsmod-build"
>  }
>  
>  # vim:set ts=2 sw=2 et:
> diff --git a/prototypes/PKGBUILD-git.proto b/prototypes/PKGBUILD-git.proto
> index 05b721b..7ece6f3 100644
> --- a/prototypes/PKGBUILD-git.proto
> +++ b/prototypes/PKGBUILD-git.proto
> @@ -59,6 +59,8 @@ build() {
>  package() {
>    cd "$srcdir/$_gitname-build"
>    make DESTDIR="$pkgdir/" install
> +
> +  rm -rf "$srcdir/$_gitname-build"
>  }
>  
>  # vim:set ts=2 sw=2 et:
> diff --git a/prototypes/PKGBUILD-hg.proto b/prototypes/PKGBUILD-hg.proto
> index 8474533..df9abd5 100644
> --- a/prototypes/PKGBUILD-hg.proto
> +++ b/prototypes/PKGBUILD-hg.proto
> @@ -60,6 +60,8 @@ build() {
>  package() {
>    cd "$srcdir/$_hgrepo-build"
>    make DESTDIR="$pkgdir/" install
> +
> +  rm -rf "$srcdir/$_hgrepo-build"
>  }
>  
>  # vim:set ts=2 sw=2 et:
> diff --git a/prototypes/PKGBUILD-svn.proto b/prototypes/PKGBUILD-svn.proto
> index a08e0e3..f103c78 100644
> --- a/prototypes/PKGBUILD-svn.proto
> +++ b/prototypes/PKGBUILD-svn.proto
> @@ -58,6 +58,8 @@ build() {
>  package() {
>    cd "$srcdir/$_svnmod-build"
>    make DESTDIR="$pkgdir/" install
> +
> +  rm -rf "$srcdir/$_svnmod-build"
>  }
>  
>  # vim:set ts=2 sw=2 et:
> -- 
> 1.7.7.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.archlinux.org/pipermail/arch-projects/attachments/20111102/6a5a0c9d/attachment.asc>