[arch-projects] [ABS] [PATCH v3 6/7] vcs prototypes: consistent coding style
seschwar at googlemail.com
Wed Nov 9 09:09:09 EST 2011
On 2011-11-08 at 21:56 -0800, Linus Arver wrote:
> Some vcs prototypes do
> cd repo && update
> while others do it like
> cd repo
> to update an existing repo. It makes sense to have them all do it the
> first way (there's nothing wrong with it, and it has better form).
I agree with the consistency issue, but not with using the first
way. makepkg is executed with `/bin/bash -e`. Whenever
a command returns a non zero exit status makepkg exits
immediately. See bash(1) or set(1p). Thus conditional checks
on single commands with && and || are seldomly required.
Even in the second case the "update" step is never reached.
I personally find the second form easier to read, as one does
not have to think about why the && was mixed in, and if this
More information about the arch-projects