[arch-projects] [ABS] [PATCH v3 3/7] git prototype: on initial clones, perform a shallow clone

Linus Arver linusarver at gmail.com
Fri Nov 11 00:08:24 EST 2011


On Thu, Nov 10, 2011 at 12:56:35PM -0600, C Anthony Risinger wrote:
> On Wed, Nov 9, 2011 at 9:46 PM, Linus Arver <linusarver at gmail.com> wrote:
> >
> > The problem I have with your sample PKGBUILD is that it is extremely
> > complicated. Anything extremely complicated goes entirely against the
> > KISS philosophy that we Arch devs/contributors cherish. See
> > https://wiki.archlinux.org/index.php/The_Arch_Way
> 
> well, the message i linked had the bits i was referring to factored
> out, and they amount to about 15-20 lines -- the PKGBUILD i linked
> *is* complex, but not complicated ... there is alot going on, and it's
> a less than trivial build.
> 
> the bits relating to git are pretty clear, imo at least.  "the arch
> way" is a great guideline -- i believe i've made the process as simple
> as it *can* be made ;-)

I think your 10-20-line excerpts outlined in
http://mailman.archlinux.org/pipermail/arch-general/2011-July/021078.html
are still extremely complicated. But maybe I'm the only one who thinks
this way (your technical competence with git is certainly above my own).

But I think that the PKGBUILD prototypes are meant to be a very simple,
sane starting point for devs/contributors to create their own. If we end
up introducing too many concepts into these prototypes, maybe they may
not be helpful in the end. Perhaps there should be two sets of
prototypes --- an "beginner" and "advanced" version. Or maybe the ideas
you introduced in your email belong to the Arch Wiki, and not the
prototype (under a heading like "Advanced Git PKGBUILD Techniques).

> > But of course, you are free to write up a separate patch series for git.
> > At this time, however, I am unwilling to delay this patch series to
> > incorporate such extensive changes.
> 
> that is fine, i was not suggesting any alteration or amendments to
> your series.  it simply reminded me of a my prior work; work i believe
> is still more than valid.  perhaps i should have created a new thread
> from it, but i'm still not 100% the expectations of this list.
> 
> no worries, i may be able to spin some patches, but i would recommend
> maybe reading my original linked proposal, as i think it labels the
> goals pretty well.

Yes, please do create a new thread/patch series. Hopefully my series
will be merged soonish.

I think you should make very small, incremental changes at a time. That
way, you won't scare off all the people on the list who are not as
technically competent in git as yourself. ;)

-Linus

P.S. When writing a list of paragraphs, use '*' or '-', not ')'.


More information about the arch-projects mailing list