[arch-projects] [PATCH 2/2] swapoff: umount swap-backed fs before switching off swap

[C Anthony Risinger]

On Mon, Oct 31, 2011 at 5:38 AM, Tom Gundersen <teg at jklm.no> wrote:
> On Mon, Oct 31, 2011 at 6:22 AM, C Anthony Risinger <anthony at xtfx.me> wrote:

it's a bit ... delayed, but shouldn't matter.  i've had this message
flagged for 2 weeks and just never wrote a response for some reason
...

> From what I could see findmnt does this if you put TARGET as your
> first column (but I couldn't find this in the docs, so maybe I was
> just lucky). If it does not, we should consider asking upstream to add
> this as it seems like a very useful feature. I'd rather avoid
> home-made solutions if we can...

i'm not sure either ... IIRC i tested after doing some --binds and
--moves and it *didn't* do it correctly, but i'd have to double check.
 generally the mountinfo table is in the correct order (mount order,
usually works), but in the presence of --move/--bind's this doesn't
always hold.

... probably won't affect -- my use case was far from normal.

>> there was mention of a shudown hook after a pivot_root recently --
>> this should work well for that.  if there is a simpler way to
>> accomplish this, i'd love to here that as well.
>
> We have a simple/hacky implementation of umount_all for the
> shutdownramfs (using only busybox features). I think we should
> consider moving this to using findmnt as well though...

has the shutdown hook already landed?  my systemd machines always
complain about not being able to free the / device (md+lvm) ...
unrelated though.

>> this isn't my original
>
> Just as a general remark: I guess we should try to avoid copying code
> that doesn't come with a license.

ok, i actually responded specifically for this line ;-)

what do you mean exactly?  copying from your perspective or mine?  i
wrote all of it on my my own time ... should i send license info along
with any code/patches sent to this list?

i just want to make sure i understand, thats all ... unless otherwise
noted, anything posted is hereby Apache2, MIT, BSD, or public domain
at will ... i own it, and so do you :-)

-- 

C Anthony