[arch-projects] [PATCH] [mkinitcpio] init: Remove unneeded test

[Gerardo Exequiel Pozzi]

----- Mensaje original -----
> De: Dave Reisner <d at falconindy.com>
> Para: Arch Linux projects development discussion <arch-projects at archlinux.org>
> CC: 
> Enviado: miércoles, 16 de noviembre de 2011 14:17
> Asunto: Re: [arch-projects] [PATCH] [mkinitcpio] init: Remove unneeded test
> 
> On Wed, Nov 16, 2011 at 02:03:31PM -0300, Gerardo Exequiel Pozzi wrote:
>>  Signed-off-by: Gerardo Exequiel Pozzi <vmlinuz386 at yahoo.com.ar>
>>  ---
>>   init |    8 +++-----
>>   1 files changed, 3 insertions(+), 5 deletions(-)
>> 
>>  diff --git a/init b/init
>>  index 7cc2d47..53c64d5 100644
>>  --- a/init
>>  +++ b/init
>>  @@ -36,11 +36,9 @@ else
>>       udevd_running=0
>>   fi
>>   
>>  -if [ -n "${disablehooks}" ]; then
>>  -    for d in ${disablehooks//,/ }; do
>>  -        eval "hook_${d}=disabled"
>>  -    done
>>  -fi
>>  +for d in ${disablehooks//,/ }; do
>>  +    eval "hook_${d}=disabled"
>>  +done
>>   
>>   earlymodules=${earlymodules//,/ }
>>   if [ -n "${earlymodules## }" ]; then
>>  -- 
>>  1.7.7.3
>> 
> 
> I meant to merge with with the other patch that gets rid of the sed
> pipe.
> 

But you already commited it.

> FYI, it doesn't look like busybox is going away any time soon, but your
> work is still much appreciated. Adding in the various binaries is no
> problem, but as soon as you're in a rescue shell, life becomes a lot
> more interesting. busybox is a real pain in the ass, but it fills in
> this particular gap rather nicely. Going forward, I think we're
> just going to override busybox with the few binaries that we need from
> real userland.
> 

OK. At this time all hooks from mkinitcpio, mdadm, cryptsetup, dmraid and lvm2 are done using built-in shell features (replaced grep, cut and sed)

Agree one thing is rescue shell and other thing is hooks. For the first is really useful busybox, for the latter we can have just the used "non-busybox-commands" (mount, cp, dd, cat, blkid, etc etc). Maybe in a future we can have a "rescue" hook thats install busybox making it optional.

> d
>