[arch-projects] [mkinitcpio][PATCH 06/11] autodetect: store rootfstype for use by other hooks

C Anthony Risinger anthony at xtfx.me
Wed Nov 16 18:13:58 EST 2011


On Wed, Nov 16, 2011 at 5:06 PM, Dave Reisner <d at falconindy.com> wrote:
> On Wed, Nov 16, 2011 at 04:54:52PM -0600, C Anthony Risinger wrote:
>> On Fri, Nov 11, 2011 at 8:55 PM, Dave Reisner <d at falconindy.com> wrote:
>> > Signed-off-by: Dave Reisner <dreisner at archlinux.org>
>> > ---
>> >  install/autodetect |    2 +-
>> >  1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/install/autodetect b/install/autodetect
>> > index 35f1cb2..5537f7c 100644
>> > --- a/install/autodetect
>> > +++ b/install/autodetect
>> > @@ -10,7 +10,7 @@ build() {
>> >
>> >     auto_modules | grep -xEv '(ata|ide)_generic' >"$MODULE_FILE"
>> >
>> > -    if ! findmnt -uno fstype "${BASEDIR:-/}" >>"$MODULE_FILE"; then
>> > +    if ! rootfstype=$(findmnt -uno fstype "${BASEDIR:-/}" | tee -a "$MODULE_FILE"); then
>> >         error "failed to detect root filesystem"
>> >         fs_autodetect_failed=1
>> >     fi
>> > --
>> > 1.7.7.3
>> >
>> >
>>
>> This patch along with associated changed to `init_functions` appears
>> to be causing `rootfstype=xyz` on kernel boot to be ignored (since
>> it's never checked) ... are we to use `fstype` in it's place?
>>
>
> Do you have a use case where specifying rootfstype is actually
> necessary?

yes 9pnet_virtio, which i am preparing a patch for to work out of the
box (ill send that shortly)

-- 

C Anthony


More information about the arch-projects mailing list