[arch-projects] [PATCH] init_functions: rework `default_mount_handler` -- assume less/succeed more

[Thomas Bächler]

Am 17.11.2011 19:01, schrieb C Anthony Risinger:
> On Thu, Nov 17, 2011 at 3:24 AM, Thomas Bächler <thomas at archlinux.org> wrote:
>> Am 17.11.2011 07:20, schrieb C Anthony Risinger:
>>> +    if ! mount ${opts} "$root" "$1"; then
>>> +        if [ ! -b "$root" ]; then
>>> +            err "Unable to determine major/minor number of root device '$root'."
>>> +        fi
>>
>> This error message no longer makes sense. Replace it by something
>> understandable.
> 
> sure, how about (as a msg instead of err):
> 
> "Is root device a /dev/<blockdev>? Unable to determine it's major/minor number."
> 
> ... or...
> 
> "Root device does not exist -- not a block device, or unable to
> locate/determine it's major/minor number."
> 
> ... something like that?

The whole major/minor comment confuses people. Simply state that the
root device does not exist and/or could not be created.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/arch-projects/attachments/20111117/a56b4d79/attachment.asc>