[arch-projects] [devtools] [PATCH 1/4] finddeps: Proper quoting, use double brackets

Lukas Fleischer archlinux at cryptocrack.de
Thu Oct 13 02:24:27 EDT 2011


Signed-off-by: Lukas Fleischer <archlinux at cryptocrack.de>
---
 finddeps |   28 +++++++++++-----------------
 1 files changed, 11 insertions(+), 17 deletions(-)

diff --git a/finddeps b/finddeps
index ded7a93..0d59634 100755
--- a/finddeps
+++ b/finddeps
@@ -3,7 +3,10 @@
 # finddeps - find packages that depend on a given depname
 #
 
-if [ "$1" = '' ]; then
+match=$1
+tld=$(pwd)
+
+if [[ -z $match ]]; then
 	echo 'usage: finddeps <depname>'
 	echo ''
 	echo 'Find packages that depend on a given depname.'
@@ -12,35 +15,26 @@ if [ "$1" = '' ]; then
 	exit 0
 fi
 
-match=$1
-tld=$(pwd)
-
-for d in $(find . -type d); do
-	cd $d
-	if [ -f PKGBUILD ]; then
+for d in "$(find . -type d)"; do
+	cd "$d"
+	if [[ -f PKGBUILD ]]; then
 		unset pkgname depends makedepends
 		. PKGBUILD
 		for dep in "${depends[@]}"; do
 			# lose the version comparator, if any
 			depname=${dep%%[<>=]*}
-			if [ "$depname" = "$match" ]; then
-				echo "$d (depends)"
-			fi
+			[[ $depname = $match ]] && echo "$d (depends)"
 		done
 		for dep in "${makedepends[@]}"; do
 			# lose the version comparator, if any
 			depname=${dep%%[<>=]*}
-			if [ "$depname" = "$match" ]; then
-				echo "$d (makedepends)"
-			fi
+			[[ $depname = $match ]] && echo "$d (makedepends)"
 		done
 		for dep in "${optdepends[@]/:*}"; do
 			# lose the version comaparator, if any
 			depname=${dep%%[<>=]*}
-			if [ "$depname" = "$match" ]; then
-				echo "$d (optdepends)"
-			fi
+			[[ $depname = $match ]] && echo "$d (optdepends)"
 		done
 	fi
-	cd $tld
+	cd "$tld"
 done
-- 
1.7.7



More information about the arch-projects mailing list