[arch-projects] [mkinitcpio][PATCH 04/26] cleanup and bashify install hooks

[Dan McGee]

On Mon, Sep 26, 2011 at 8:22 PM, Dave Reisner <d at falconindy.com> wrote:
> This introduces no logical code changes -- this is purely a syntactical
> cleanup and standardization across the build hooks. All hooks get the
> same treatment, adhering to the following style:
>
>  #!/bin/bash
>
>  build() {
>      COMMANDS
>  }
>
>  help() {
>      cat <<HELPEOF
>  This is a help message.
>  HELPEOF
>  }
>
>  # vim: set ft=sh ts=4 sw=4 et:
>
> Signed-off-by: Dave Reisner <dreisner at archlinux.org>
> ---
>  install/btrfs       |   15 ++--
>  install/dsdt        |   21 ++----
>  install/filesystems |    2 +-
>  install/fw          |   29 +++-----
>  install/ide         |   30 +++-----
>  install/keymap      |    2 +-
>  install/memdisk     |   19 +++---
>  install/net         |  195 +++++++++++++++++++++++++--------------------------
>  install/pata        |    2 +-
>  install/pcmcia      |   28 ++++----
>  install/resume      |   19 ++---
>  install/sata        |    2 +-
>  install/scsi        |    2 +-
>  install/sleep       |   27 +++----
>  install/udev        |   33 ++++-----
>  install/usb         |   30 ++++-----
>  install/usbinput    |   30 +++-----
>  17 files changed, 220 insertions(+), 266 deletions(-)
>
> -help ()
> -{
> -cat <<HELPEOF
> -  This hook is needed to support Btrfs volumes spread
> -  over multiple devices.
> +help() {
> +    cat <<HELPEOF
> +This hook is needed to support Btrfs volumes spread over multiple devices.
>  HELPEOF
Any reason for re-wrapping the help messages you didn't change? Or at
least mention in the commit message "all help text has been re-wrapped
to 76/80/whatever characters."

-Dan