[arch-projects] [mkinitcpio][PATCH 21/26] lsinitcpio: disable color when stdout isn't a tty

Dave Reisner d at falconindy.com
Mon Sep 26 22:10:57 EDT 2011


On Mon, Sep 26, 2011 at 09:05:21PM -0500, Dan McGee wrote:
> On Mon, Sep 26, 2011 at 9:01 PM, Dave Reisner <d at falconindy.com> wrote:
> > On Mon, Sep 26, 2011 at 08:57:40PM -0500, Dan McGee wrote:
> >> On Mon, Sep 26, 2011 at 8:22 PM, Dave Reisner <d at falconindy.com> wrote:
> >> > Signed-off-by: Dave Reisner <dreisner at archlinux.org>
> >> Why were we using stderr before? Did something else change?
> >
> > You really wanna know? Copy/paste job from makepkg. We should fix this
> > over in makepkg as well. I'm not sure why it's used there either.
> 
> makepkg -g >> PKGBUILD.
> 
> Now whether that is a good reason is up for some debate, but you asked. :)
> 
> -Dan

Did I say fix? I meant makepkg is wonderful. Yeah, we don't have any
such need in lsinitcpio. But, people do enjoy writing the output from
this program to a pastebin or a pager, so disabling color on [[ ! -t 1 ]]
is the nice thing to do.

d


More information about the arch-projects mailing list