[arch-projects] [netcfg] [PATCH 1/3] systemd: Fix description and other details of net-auto-wire{d, less}.service

[Jouke Witteveen]

On Thu, Oct 25, 2012 at 11:20 PM, Thomas Bächler <thomas at archlinux.org> wrote:
> ---
>  systemd/net-auto-wired.service    | 4 +++-
>  systemd/net-auto-wireless.service | 3 +--
>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/systemd/net-auto-wired.service b/systemd/net-auto-wired.service
> index 7bb885d..badaebf 100644
> --- a/systemd/net-auto-wired.service
> +++ b/systemd/net-auto-wired.service
> @@ -1,5 +1,7 @@
>  [Unit]
> -Description=Provides automatic netcfg wired connection
> +Description=Automatic wired network connection
> +Before=network.target
> +Wants=network.target

No! FS#32161

>
>  [Service]
>  EnvironmentFile=/etc/conf.d/netcfg
> diff --git a/systemd/net-auto-wireless.service b/systemd/net-auto-wireless.service
> index ab57ab9..e437a64 100644
> --- a/systemd/net-auto-wireless.service
> +++ b/systemd/net-auto-wireless.service
> @@ -1,5 +1,5 @@
>  [Unit]
> -Description=Provides automatic netcfg wireless connection
> +Description=Automatic wireless network connection
>  Before=network.target
>  Wants=network.target
>
> @@ -7,7 +7,6 @@ Wants=network.target
>  EnvironmentFile=/etc/conf.d/netcfg
>  ExecStart=/usr/bin/netcfg-wpa_actiond $WIRELESS_INTERFACE
>  ExecStop=/usr/bin/netcfg-wpa_actiond stop $WIRELESS_INTERFACE
> -RemainAfterExit=yes
>  Type=forking
>
>  [Install]
> --
> 1.8.0
>

One gripe: wouldn't it be better to mention 'netcfg' in the
descriptions, somehow?