[arch-projects] [mkinitcpio] [RFC] add_module(): silently ignore built-ins

Matthew Monaco dgbaley27 at 0x01b.net
Mon Sep 17 10:45:20 EDT 2012


On 09/17/2012 08:38 AM, Dave Reisner wrote:
> On Mon, Sep 17, 2012 at 10:10:36AM -0400, Dave Reisner wrote:
>> I like the idea, but the lookup is a bit heavy and there's no caching. I threw
>> together the below unpolished diff, which is a bit snappier and gets the job
>> done.
> 
> Replying to myself ftw... I commited a pair of patches to my dev repo
> which convert the whole ADDED_MODULES array to a hash and then just
> "prime" this hash with the contents of the builtin file. It's quite a
> nice improvement overall:
> 
> http://code.falconindy.com/cgit/mkinitcpio.git/commit/?id=1f1085e
> http://code.falconindy.com/cgit/mkinitcpio.git/commit/?id=5626743
> 

Much more elegant. Thanks!



More information about the arch-projects mailing list