[arch-projects] [PATCH] [abs] Clean up prototypes (quoting, links in comments, etc.)
Jason St. John
jstjohn at purdue.edu
Sun Apr 7 21:24:36 EDT 2013
On Sun, Apr 7, 2013 at 9:13 PM, Allan McRae <allan at archlinux.org> wrote:
> On 08/04/13 11:04, Jason St. John wrote:
>> On Sun, Apr 7, 2013 at 8:49 PM, Allan McRae <allan at archlinux.org> wrote:
>>> On 08/04/13 10:44, Jason St. John wrote:
>>>> From: "Jason St. John" <jstjohn at purdue.edu>
>>>> Many instances in the prototypes did not contain quotes where variables
>>>> would be expanded or in arrays (e.g. 'depends=(ruby)'). This commit adds
>>>> quotes in all identified areas as appropriate.
>>>> This commit also removes the hard-coded path to gconfpkg in
>>>> proto-gnome.install and removes the legacy '|| return 0' in
>>> That is not legacy but entirely necessary...
>> It was my understanding that '|| return 0' was no longer necessary
>> with recent versions of pacman/makepkg. Is that only true in PKGBUILD
> In a PKGBUILD, not and install script.
> That is specifically testing if texinfo is available and stopping if not.
I just resubmitted this patch, which you can see here:
More information about the arch-projects