[arch-projects] [netctl] [PATCH] Updated documentation for pppoe and mobile_ppp

[Robbie Smith]

On 16/04/13 17:45, Jouke Witteveen wrote:
> On Sun, Apr 14, 2013 at 1:40 PM, Robbie Smith <zoqaeski at gmail.com> wrote:
>> On 13/04/13 21:09, Jouke Witteveen wrote:
>>>
>>> On Thu, Apr 11, 2013 at 4:03 PM, Robbie Smith <zoqaeski at gmail.com> wrote:
>>>>
>>>> I’ve updated the documentation for the pppoe and mobile_ppp connections
>>>> in
>>>> the netctl.profile(5) manpage. How should I submit it, a patch to this
>>>> list
>>>> or a pull-request to the git repo on projects.archlinux.org?
>>>
>>>
>>> A pull-request is a bit hard to review (and thats one thing this list
>>> is for). Therefore I prefer patches to the list (git format-patch
>>> style for ease of applying).
>>>
>>> The changes to the documentation look good, although there are some
>>> indentation issues. In the documentation all lines should be within 72
>>> characters and indentation is 4 spaces deep.
>>>
>>> I'm looking forward to your patches,
>>> - Jouke
>>>
>
> Hi Robbie,
>
>> Here’s the patch for the documentation.
>
> Ah, but in this form (patch as attachment), we still don't have the
> benefits we could. I'll deal with it for this one, but next time, make
> sure to use `git format-patch`, so that the patch is in-lined, easy to
> review and easy to apply.
>
> On a different note, is this okay with you?
> https://github.com/joukewitteveen/netctl/pull/26/files
>
> Regards,
> - Jouke
>
I’m new to contributing to open-source projects, so finding out how to 
format and submit contributions feels a bit trial-and-error. Is there 
information for new contributors in, say, the (dev) wiki?

And yeah, that patch is fine. I’ve only implemented the code that I 
needed to get my modem to work, so there’s almost certainly things that 
I’ve missed. Hopefully no (major) bugs but definitely missing features.

- Robbie