[arch-projects] [DEVTOOLS][PATCH 1/2] Allow makechroot options in archbuild

[Allan McRae]

On 02/01/13 10:45, Dave Reisner wrote:
> On Wed, Jan 02, 2013 at 01:42:44AM +0100, Sébastien Luttringer wrote:
>> This will allow, by example, to easily build a package with a custom pkg.
>>
>> staging-x86_64-build -- -cI /var/cache/pacman/pkg/ldoc-1.2.0-1-any.pkg.tar.xz
>> staging-x86_64-build -- -n
>>
>> Signed-off-by: Sébastien Luttringer <seblu at seblu.net>
>> ---
>>  archbuild.in | 16 ++++++++++++----
>>  1 file changed, 12 insertions(+), 4 deletions(-)
>>
>> diff --git a/archbuild.in b/archbuild.in
>> index 10d33b8..44288df 100644
>> --- a/archbuild.in
>> +++ b/archbuild.in
>> @@ -3,6 +3,7 @@
>>  m4_include(lib/common.sh)
>>  
>>  base_packages=(base base-devel sudo)
>> +makechrootpkg_args=(-c -n)
> 
> You're proposing making cleaning the chroot the default? Definitely not
> needed or wanted...
> 

Cleaning already is the default:

>> -exec setarch "${arch}" makechrootpkg -c -n -r "${chroots}/${repo}-${arch}"
>> +exec setarch "${arch}" makechrootpkg "${makechrootpkg_args[@]}" -r "${chroots}/${repo}-${arch}"

No change there.

There is a difference between "testing-i686-build -c" and "makechrootpkg
-c".

Anyway, I have to do this all the time with some of my packages and I
think it best in these cases to use makechrootpkg directly.  In fact...
 that is all I use.

Allan