[arch-projects] [devtools][PATCH] checkpkg: Fix soname check

[Dave Reisner]

On Wed, Oct 23, 2013 at 11:24:45PM -0400, Eric Bélanger wrote:
> The bsdtar options were in the incorrect order and objdump couldn't find the files.
> 
> Signed-off-by: Eric Bélanger <snowmaniscool at gmail.com>
> ---
>  checkpkg.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/checkpkg.in b/checkpkg.in
> index ef46399..02c6543 100644
> --- a/checkpkg.in
> +++ b/checkpkg.in
> @@ -73,9 +73,9 @@ for _pkgname in "${pkgname[@]}"; do
>  
>  	if diff "$TEMPDIR/filelist-$_pkgname"{-old,} | grep '\.so' &>/dev/null; then
>  		mkdir -p "$TEMPDIR/pkg"
> -		bsdtar -C "$TEMPDIR" xf ../"$pkgfile" #> /dev/null
> +		bsdtar x -C "$TEMPDIR" -f "$pkgfile" #> /dev/null

Problem here doesn't seem to be order of flags, but the missing '-'
before 'xf'.

>  		diff "$TEMPDIR/filelist-$_pkgname-old" "$TEMPDIR/filelist-$_pkgname" | awk '/>.*\.so/{$1 = ""; print $0}' | while read i; do
> -			echo "${i}: " "$(objdump -p "$i" | grep SONAME)"
> +			echo "${i}: " "$(objdump -p "$TEMPDIR/$i" | grep SONAME)"
>  		done
>  	else
>  		msg "No soname differences for $_pkgname."
> -- 
> 1.8.4.1
>