[arch-projects] [devtools] [PATCH 1/2] makechrootpkg: specify makepkg.conf with -M

[Alad Wenter]

Jan Alexander Steffens via arch-projects wrote:
>
>
> On Wed, Jul 20, 2016 at 1:07 PM Alad Wenter <alad at archlinux.info
> <mailto:alad at archlinux.info>> wrote:
>
>     Johannes Löthberg via arch-projects wrote:
>     > On 19/07, Alad Wenter wrote:
>     >> PKGDEST and other variables can be set in /etc/makepkg.conf and
>     local
>     >> correspondents in $HOME, with the file in /etc taking precedence.
>     >> Specifying a default makepkg.conf on the command line (similar to
>     >> makepkg) allows to change the directory where build products
>     are moved
>     >> (move_products), without the need to modify the system
>     configuration
>     >> in /etc/makepkg.conf or rely on sudoers policy.
>     >>
>     >
>     > Aah, /etc/makepkg.conf shouldn't take precedence, that's a bug.
>     >
>     Right, so the two load_vars lines should be swapped. Would you say
>     there's still a use in an -M switch? A program may want to change
>     PKGDEST and other variables, without modifying user configuration,
>     either.
>
>     Another question: load_vars has -f $makepkg_conf; this should probably
>     be -r $makepkg_conf as in makepkg?
>
>
> Note that load_vars does not read variables that have been set
> already. So the order is correct.
Oh, clever. In that case I'd suggest to instead expand the usage
section, as it differs from makepkg. For example:

"makechrootpkg reads *DEST, PACKAGER and MAKEFLAGS from
/etc/makepkg.conf and $XDG_CONFIG_HOME/pacman/makepkg.conf (in this
order), if those variables were not set already for example, from the
sudo command line)."

Thoughts?