[arch-projects] [mkinitcpio] [PATCH 1/1] fix variable name and correctly report broken dynamic linking

Dave Reisner d at falconindy.com
Sun Nov 20 13:40:39 UTC 2016


On Sun, Nov 20, 2016 at 01:07:11AM +0100, Christian Hesse wrote:
> From: Christian Hesse <mail at eworm.de>
> 
> With broken dynamic linking an error was reported, but mkinitcpio still
> exited with:
> 
> ==> Image generation successful
> 
> and return code 0. This fixes the variable name, which makes mkinitcpio
> exit with the correct warning:
> 
> ==> WARNING: errors were encountered during the build. The image may not
> be complete.
> 
> and return code 1, indicating an error.
> 
> Signed-off-by: Christian Hesse <mail at eworm.de>
> ---

Thanks! I already have this pending in my local checkout, though.

>  functions | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/functions b/functions
> index 7785347..14235b2 100644
> --- a/functions
> +++ b/functions
> @@ -590,7 +590,7 @@ add_binary() {
>              sodep=${BASH_REMATCH[1]}
>          elif [[ $line = *'not found' ]]; then
>              error "binary dependency \`%s' not found for \`%s'" "${line%% *}" "$1"
> -            (( ++builderrors ))
> +            (( ++_builderrors ))
>              continue
>          fi
>  
> -- 
> 2.10.2


More information about the arch-projects mailing list