[arch-projects] [dbscripts] [PATCH] Do not support wildcards in PKGEXT, and standardize on xz compression.
lukeshu at lukeshu.com
Fri Feb 16 01:00:49 UTC 2018
On Thu, 15 Feb 2018 17:53:08 -0500,
Eli Schwartz via arch-projects wrote:
> Since devtools pushes xz, and every single package currently in the
> repos uses xz,
FWIW, devtool's lib/common.sh's find_cached_package() uses the glob
> and AFAIK we haven't actually used any others, it makes
> sense to just assume xz as the only supported PKGEXT.
IIRC, .gz was used for some packages until around ~2011.
Until 2011-03-26 the glob was ".pkg.tar.*", but in 575ba47 it was
changed to the current ".pkg.tar.?z" as part of supporting package
signing (so that it wouldn't match the .pkg.tar.*.sig files).
If my recollection of having .gz files is correct, that change makes a
bit of pragmatic sense; .gz and .xz were the extensions in use when
that change was made.
As for continuing to support globs: that's functionality that will be
needed if the prescribed PKGEXT ever changes. It isn't enough to
simply change dbscripts' PKGEXT to the new one; for some time after
that, it will need to be able to find packages with the old extension
(imagine if ftpdir-cleanup stopped seeing the old extension!)
IDK if you guys think it's worth keeping the the globbing code around
just for the eventuality that a new compression scheme comes around.
If not, I'm fine with this change.
~ Luke Shumaker
More information about the arch-projects