[arch-projects] [dbscripts] [PATCH v2 4/8] Correctly treat PKGEXT_glob as a glob

Luke Shumaker lukeshu at lukeshu.com
Sun Feb 18 18:19:48 UTC 2018


On Sun, 18 Feb 2018 12:17:32 -0500,
Luke Shumaker wrote:
> 
> diff --git a/test/cases/ftpdir-cleanup.bats b/test/cases/ftpdir-cleanup.bats
> index 7dfad4a..efc18a8 100644
> --- a/test/cases/ftpdir-cleanup.bats
> +++ b/test/cases/ftpdir-cleanup.bats
> @@ -13,8 +13,8 @@ __checkRepoRemovedPackage() {
>  	local pkgname
>  
>  	for pkgname in $(__getPackageNamesFromPackageBase ${pkgbase}); do
> -		[[ ! -f ${FTP_BASE}/${PKGPOOL}/${pkgname}-*${PKGEXT_glob} ]]
> -		[[ ! -f ${FTP_BASE}/${repo}/os/${repoarch}/${pkgname}-*${PKGEXT_glob} ]]
> +		! is_globfile "${FTP_BASE}/${PKGPOOL}/${pkgname}"-*${PKGEXT_glob}
> +		! is_globfile "${FTP_BASE}/${repo}/os/${repoarch}/${pkgname}"-*${PKGEXT_glob}
>  	done

Shoot, that needs to be __isGlobfile; we don't load db-functions here;
is_globfile is undefined.  It's basically doing "! false".

No mater how many times you look over it before hitting send...

-- 
Happy hacking,
~ Luke Shumaker


More information about the arch-projects mailing list