[arch-projects] [devtools] [PATCH 3/7] arch-nspawn: make sure that makepkg.conf is always parsed as text

[Bartłomiej Piotrowski]

On 2018-01-15 18:11, Eli Schwartz via arch-projects wrote:
> On 01/15/2018 11:57 AM, Luke Shumaker wrote:
>> From: Luke Shumaker <lukeshu at parabola.nu>
>>
>> https://lists.parabola.nu/pipermail/dev/2017-June/005576.html
>> ---
>>  arch-nspawn.in | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch-nspawn.in b/arch-nspawn.in
>> index c55f498..3949ee1 100644
>> --- a/arch-nspawn.in
>> +++ b/arch-nspawn.in
>> @@ -107,7 +107,7 @@ fi
>>  build_mount_args
>>  copy_hostconf
>>  
>> -eval "$(grep '^CARCH=' "$working_dir/etc/makepkg.conf")"
>> +eval "$(grep -a '^CARCH=' "$working_dir/etc/makepkg.conf")"
>>  
>>  [[ -z $nosetarch ]] || unset CARCH
> 
> I'm curious, in what situation were you having grep parse makepkg.conf
> as not text?
> 
> I also wonder whether we should source makepkg.conf in a subshell and
> printf the relevant variables...
> 

Used to happen with my "ł" in ~/.makepkg.conf, so sounds generally useful.