[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-73-gda49ea6

eschwartz at archlinux.org eschwartz at archlinux.org
Fri Mar 16 02:48:10 UTC 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Official repo DB scripts".

The branch, master has been updated
       via  da49ea616e162d3cfcb4b6a4242f497e94c36564 (commit)
       via  4ae3ea2f71344045fa4990c0524b4c662ab83cfc (commit)
       via  33aae318542016f66d2f0e09654606649d404ff2 (commit)
       via  f22f1554720da245955337782ce554d5c3f93c8c (commit)
      from  e53cad6e4a8284165c6d0b2c7c86f6c077be693b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit da49ea616e162d3cfcb4b6a4242f497e94c36564
Author: Luke Shumaker <lukeshu at parabola.nu>
Date:   Thu Feb 22 21:15:40 2018 -0500

    test: Fixup glob matching
     - ftpdir-cleanup.bats: Glob expansion does not occur in [[ -f ]] tests.
       The [[ ! -f .../${pkgname}-*${PKGEXT} ]] checks were checking that there
       were no files containing a literal '*' for that part of their name.
       Obviously, this isn't what was intended.
     - sourceballs.bats: [ -r ] checks explode if the glob returns >1 file.
       Avoid using them if the path being checked contains a glob.

commit 4ae3ea2f71344045fa4990c0524b4c662ab83cfc
Author: Luke Shumaker <lukeshu at parabola.nu>
Date:   Thu Feb 22 21:15:39 2018 -0500

    test: common.bash:__getCheckSum: Don't rely on IFS
    I managed to stumble across a bug in BATS where the run() function
    screwed with the global IFS.  The bug has been fixed in git, but isn't
    in a release yet.
    Anyway, this bug breaks __getCheckSum().  Fortunately, we have avoided
    tripping it so far because luck has it that we never call
    __getCheckSum() after run() in the same test.
    So, there's nothing actually broken here, but it makes me nervous.  So
    go ahead and modify __getCheckSum to not rely on IFS.
    And, while we're at it: declare the result variable and set it as
    separate commands.  Doing both in the same command masks the exit code
    of the subshell expansion.  We don't explicitly check the exit code,
    but BATS runs the test suite with `set -e`, so splitting it does mean
    that BATS will now detect errors from sha1sum.  We don't really expect
    that to happen, but if BATS will give us error checking on it for
    free, why not?

commit 33aae318542016f66d2f0e09654606649d404ff2
Author: Luke Shumaker <lukeshu at parabola.nu>
Date:   Thu Feb 22 21:15:41 2018 -0500

    Update messages to make fuller use of printf formatters
    These are things that were (IMO) missed in 5afac1e.  I found them using:
        git grep -E '(plain|msg|msg2|warning|error|die) "[^"]*\$'
    I went a little above-and-beyond for escaping strings for the error
    messages in db-functions' arch_repo_add and arch_repo_remove.  The
    code should explain itself, but I wanted to point it out, as it's more than
    the usual "slap %s in there, and move the ${...} to the right".

commit f22f1554720da245955337782ce554d5c3f93c8c
Author: Eli Schwartz <eschwartz at archlinux.org>
Date:   Mon Feb 26 17:57:31 2018 -0500

    db-functions: unify the repo-add/repo-remove caller
    Use less duplicated logic, opening the way to more elegantly change
    the interface for the repo-add/repo-remove scripts which are themselves
    symlinked together and mostly have the same interface.


Summary of changes:
 cron-jobs/ftpdir-cleanup       |  8 ++++----
 cron-jobs/integrity-check      |  2 +-
 cron-jobs/sourceballs          |  8 ++++----
 db-functions                   | 34 ++++++++++++----------------------
 db-move                        |  8 ++++----
 db-remove                      |  4 ++--
 db-repo-add                    |  4 ++--
 db-repo-remove                 |  4 ++--
 db-update                      |  4 ++--
 test/cases/ftpdir-cleanup.bats |  4 ++--
 test/cases/sourceballs.bats    |  4 ++--
 test/lib/common.bash           | 15 +++++++++++++--
 testing2x                      |  2 +-
 13 files changed, 51 insertions(+), 50 deletions(-)

Official repo DB scripts

More information about the arch-projects mailing list