From eschwartz at archlinux.org  Mon Dec  2 07:03:05 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Mon, 2 Dec 2019 02:03:05 -0500
Subject: [arch-projects] [devtools] [GIT] The official devtools
 repository branch master updated. 20191016-20-g4c803b9
In-Reply-To: <20191130123110.923BA2B788@luna.archlinux.org>
References: <20191130123110.923BA2B788@luna.archlinux.org>
Message-ID: <8973dc40-a0c8-66c5-8089-9f61bdc865fa@archlinux.org>

On 11/30/19 7:31 AM, Levente Polyak via arch-projects wrote:

Generally some nice improvements, but what is the deal with this???

> commit 104c5bc90e259028f5c9352a32f8976aa0f95a8d
> Author: Levente Polyak <anthraxx at archlinux.org>
> Date:   Sat Nov 30 13:13:49 2019 +0100
> 
>     makechrootpkg: sync database for checkpkg to avoid nonexistent targets
>     
>     For build servers or similar infrastructure its relatively common to not
>     sync/update the database regularly. This leads to problems properly
>     running checkpkg duo to nonexistent target files that we try to
>     download. As building on build servers is a very common use case, lets
>     ensure we sync the local database before trying to resolve the package
>     locations.

This commit means that devtools is not suitable for installation on any
archlinux system (including the systems owned and maintained by
Developers and Trusted Users) other than the single build server which
you've declared to be a common, yet not exclusive, use case of devtools.

One can solve the problem with outdated databases by regularly updating,
or by having dragon.archlinux.org do a periodic pacman -Sy and relying
on devops to not break the box by using pacman -S without -u.

Devtools is now a direct cause of noncompliance with
https://wiki.archlinux.org/index.php/System_maintenance#Partial_upgrades_are_unsupported,
and this will affect both users who follow the recommended best
practices to build/test AUR packages using extra-x86_64-build, as well
as Developers and Trusted Users who prefer to build on their own
hardware, but do not expect running extra-x86_64-build to sneakily
modify their pacman database out from under them.

Please revert.

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/arch-projects/attachments/20191202/7a53efcc/attachment.sig>

From eschwartz at archlinux.org  Mon Dec  2 20:51:21 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Mon,  2 Dec 2019 15:51:21 -0500
Subject: [arch-projects] [devtools] [PATCH] offload-build: return failure if
 no package files were found
Message-ID: <20191202205121.70888-1-eschwartz@archlinux.org>

This means that the remote command died at some stage earlier than the
printing of created files.

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---
 offload-build | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/offload-build b/offload-build
index dab036d..e607a16 100755
--- a/offload-build
+++ b/offload-build
@@ -116,4 +116,6 @@ if (( ${#files[@]} )); then
     printf '%s\n' '' '-> copying files...'
     load_makepkg_config
     scp "${files[@]/#/$server:}" "${PKGDEST:-${PWD}}/"
+else
+    exit 1
 fi
-- 
2.24.0

From anthraxx at archlinux.org  Tue Dec 10 20:41:06 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Tue, 10 Dec 2019 20:41:06 +0000 (UTC)
Subject: [arch-projects] [devtools] [GIT] The official devtools repository
 branch master updated. 20191130-4-gd6866e0
Message-ID: <20191210204106.9FBE82B792@luna.archlinux.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The official devtools repository".

The branch, master has been updated
       via  d6866e0544581840cc021e4be68c1c450fcb7963 (commit)
       via  8edad226166eb6f2888b87cf8e0a9952822c887a (commit)
       via  f20435643f55c37e3f8274a03e7fe5e052dc8dd9 (commit)
      from  8d99df602d6e5fc377a37f67d0e5ce74c8facecd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d6866e0544581840cc021e4be68c1c450fcb7963
Author: Levente Polyak <anthraxx at archlinux.org>
Date:   Wed Dec 4 12:39:34 2019 +0100

    lib: support arbitrary compressed package files
    
    We need to modify the matching of valid package files to support formats
    like zstd. Let's try to use an eager approach instead of a simple
    whitelist in order to be functional for arbitrary formats that may be
    introduced in the future without the need to adjust any code.
    
    Allow any single fragment word as compression type but filter out known
    non-package content like signature files.
    
    Signed-off-by: Levente Polyak <anthraxx at archlinux.org>

commit 8edad226166eb6f2888b87cf8e0a9952822c887a
Author: Eli Schwartz <eschwartz at archlinux.org>
Date:   Mon Dec 2 15:51:21 2019 -0500

    offload-build: return failure if no package files were found
    
    This means that the remote command died at some stage earlier than the
    printing of created files.
    
    Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>

commit f20435643f55c37e3f8274a03e7fe5e052dc8dd9
Author: Levente Polyak <anthraxx at archlinux.org>
Date:   Tue Dec 3 01:14:35 2019 +0100

    makechrootpkg: sync databases for checkpkg off-site
    
    Use pacman's --dbpath feature to sync fresh databases inside an isolated
    location and split up the database sync and package location calls to
    remove the need of weird grep calls.
    
    It isn't nice of makechrootpkg to modify the host database state just by
    building packages. No foreign program shall automatically modify
    the host database other than by the explicit will of a system
    maintainer, which is the major reason this changes get incorporated.
    
    However, there is certain indoctrinated believe that using -Sy is
    the prime evil. In fact it has been declared as a social rule to a
    technical problem of not getting into potential partial upgrade states.
    This is not a proper loophole less solution as there are multiple ways
    and use cases that lead to such a state, like aborting a -Syu on the
    prompt for whatever reason, what really matters is that it is not a
    technically bullet proof solution to solve the problem.
    
    Databases shall have the freedom to be as up to date as databases or
    their owner wishes, allowing querying on latest database state without
    fear. The only loophole-less contract that _really_ is from importance
    is always using -Su instead of plain -S to install packages. Installing
    packages is what actually brings one into a potential partial upgrade
    state and by using -Su an outstanding upgrade is forced when installing
    a new package. This properly solves all edge cases in a technical
    manner instead of declaring people who abort the prompt of -Syu to be
    the problem. In fact, using this simple contract allows whatever system
    maintenance workflow a host owner wants to follow, which may still be to
    always use -Syu and deal with system upgrades explicitly instead of the
    time when installing new packages, but the -Su contract is the real safe
    guard to guarantee no edge case can ever slip in. This magically also
    opens up the freedom to people who wish to use -Sy to simply query on up
    to date data as the currently indoctrinated "never do -Sy" stone plates
    not only are not rock solid in technical terms but also make certain use
    cases simply impossible and hence cripple the functionality without at
    the very least being fully loophole free.
    
    Signed-off-by: Levente Polyak <anthraxx at archlinux.org>

-----------------------------------------------------------------------

Summary of changes:
 lib/common.sh    |  4 ++--
 makechrootpkg.in | 15 +++++++++++++--
 offload-build    |  2 ++
 3 files changed, 17 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
The official devtools repository

From anthraxx at archlinux.org  Tue Dec 10 20:42:48 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Tue, 10 Dec 2019 20:42:48 +0000 (UTC)
Subject: [arch-projects] [devtools] [GIT] The official devtools repository
 branch sogrep_redirect deleted. 20190912-11-g7f849ea
Message-ID: <20191210204248.DE9A82B794@luna.archlinux.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The official devtools repository".

The branch, sogrep_redirect has been deleted
       was  7f849ea58d6a46631017b928285ebf3ff4ce6c69

- Log -----------------------------------------------------------------
7f849ea58d6a46631017b928285ebf3ff4ce6c69 sogrep: redirect to destination mirror
-----------------------------------------------------------------------


hooks/post-receive
-- 
The official devtools repository

From anthraxx at archlinux.org  Thu Dec 12 00:02:43 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Thu, 12 Dec 2019 00:02:43 +0000 (UTC)
Subject: [arch-projects] [devtools] [GIT] The official devtools repository
 branch master updated. 20191130-5-gd4546c5
Message-ID: <20191212000243.3E3DA2B7A2@luna.archlinux.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The official devtools repository".

The branch, master has been updated
       via  d4546c59ce2731a96d336f9953108816ff4b954b (commit)
      from  d6866e0544581840cc021e4be68c1c450fcb7963 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d4546c59ce2731a96d336f9953108816ff4b954b
Author: Levente Polyak <anthraxx at archlinux.org>
Date:   Thu Dec 12 01:01:44 2019 +0100

    Version 20191212

-----------------------------------------------------------------------

Summary of changes:
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
The official devtools repository

From anthraxx at archlinux.org  Thu Dec 12 00:03:09 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Thu, 12 Dec 2019 00:03:09 +0000 (UTC)
Subject: [arch-projects] [devtools] [GIT] The official devtools repository
 annotated tag 20191212 created. 20191212
Message-ID: <20191212000309.6E8FE2B7A2@luna.archlinux.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The official devtools repository".

The annotated tag, 20191212 has been created
        at  7a55fc0fb9bfbd1341de76405b26de70cc54ec64 (tag)
   tagging  d4546c59ce2731a96d336f9953108816ff4b954b (commit)
  replaces  20191130
 tagged by  Levente Polyak
        on  Thu Dec 12 01:01:45 2019 +0100

- Log -----------------------------------------------------------------
Version 20191212
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE4kC1fixGMLp2ji8m/BtUfI2BcsgFAl3xg2kACgkQ/BtUfI2B
cshpsg/+Ll13/q+GHDx7w7HvM+zDajv26XqeVR2snu2mZkwRhCa8sV603HixXTwY
D5DHDOQidylIpaYLmcVyc15Ed37y7IK58yiGt4uhViVHwh2pevIN+XhhKvbcez9L
IhjsPb/ZLg9a/gFKsvsHVaWWD98WYUCSTyORVuJgpbYT7nHUb0pAz1+wRZBEXnlQ
ogR/nXzVOaSa/eSO0YBzTgn4AYJP75ylijFzlXKrRRPxC5QRGU3nyajsoAt2UlS+
kteMiGJpH3qzi7NLyf+hBhjYQrxPUZrMcjoLXdRrtPCB/wX8VMdaOdtDLbFdLBwC
5ZBCqkNw6X5A9XkKOh4HxScsBWcBMQaFcilensvV5mVyy/iz0jadu5VpUhxp9Y9r
lM1UZsvC1IP6jmmtkMyoWTemZTX4KYQe6Nh5WxV1QXYvirFBNf/zkH9pUf8eidDq
3aS8zQF8NSnZ2HQspK2edQf6Zaurb2jHa3MvOhR4TazkIVIVuGiidOgtW3fKIPZO
eA4QUrt9HnVXIK96XZV8Ybde185xceok9KQgGA+UIkKWjOrGtD5XFVIbTGSez4ip
M02Kbdmw7l7K2TMiLLqnnq1qb98j/z/lPGdc9yD7VZ/dDJVitvOKajVaudNwyEIp
PfxU8rpArfYHyCVIhTxX7yWmecMyNBW5nxLIuL0oC09RB2u/c3A=
=ge4p
-----END PGP SIGNATURE-----

Eli Schwartz (1):
      offload-build: return failure if no package files were found

Levente Polyak (4):
      makechrootpkg: double quote array expansions for checkpkg locations
      makechrootpkg: sync databases for checkpkg off-site
      lib: support arbitrary compressed package files
      Version 20191212

-----------------------------------------------------------------------


hooks/post-receive
-- 
The official devtools repository

From eschwartz at archlinux.org  Mon Dec 16 20:46:07 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Mon, 16 Dec 2019 15:46:07 -0500
Subject: [arch-projects] [devtools] [PATCH 1/3] makerepropkg: fix wonky
 indent
In-Reply-To: <20191216204609.111647-1-eschwartz@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
Message-ID: <20191216204609.111647-2-eschwartz@archlinux.org>

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---
 makerepropkg.in | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/makerepropkg.in b/makerepropkg.in
index 710f3ca..2b0945e 100755
--- a/makerepropkg.in
+++ b/makerepropkg.in
@@ -101,12 +101,12 @@ __EOF__
 }
 
 while getopts 'M:c:h' arg; do
-        case "$arg" in
-                M) archroot_args+=(-M "$OPTARG") ;;
-                c) cache_dirs+=("$OPTARG") ;;
-                h) usage; exit 0 ;;
-                *|?) usage; exit 1 ;;
-        esac
+    case "$arg" in
+        M) archroot_args+=(-M "$OPTARG") ;;
+        c) cache_dirs+=("$OPTARG") ;;
+        h) usage; exit 0 ;;
+        *|?) usage; exit 1 ;;
+    esac
 done
 shift $((OPTIND - 1))
 
-- 
2.24.1

From eschwartz at archlinux.org  Mon Dec 16 20:46:08 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Mon, 16 Dec 2019 15:46:08 -0500
Subject: [arch-projects] [devtools] [PATCH 2/3] makerepropkg: add support to
 check unreproducible packages using diffoscope
In-Reply-To: <20191216204609.111647-1-eschwartz@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
Message-ID: <20191216204609.111647-3-eschwartz@archlinux.org>

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---
 doc/makerepropkg.1.asciidoc |  3 +++
 makerepropkg.in             | 14 +++++++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/doc/makerepropkg.1.asciidoc b/doc/makerepropkg.1.asciidoc
index 7d68e5e..301b73e 100644
--- a/doc/makerepropkg.1.asciidoc
+++ b/doc/makerepropkg.1.asciidoc
@@ -26,6 +26,9 @@ link:https://reproducible-builds.org/[Reproducible Builds] project.
 Options
 -------
 
+*-d*::
+	If packages are not reproducible, compare them using diffoscope.
+
 *-c*::
 	Set the pacman cache directory.
 
diff --git a/makerepropkg.in b/makerepropkg.in
index 2b0945e..60fee95 100755
--- a/makerepropkg.in
+++ b/makerepropkg.in
@@ -29,6 +29,7 @@ declare -a buildenv buildopts installed installpkgs
 archiveurl='https://archive.archlinux.org/packages'
 buildroot=/var/lib/archbuild/reproducible
 chroot=testenv
+diffoscope=0
 
 parse_buildinfo() {
     local line var val
@@ -94,14 +95,16 @@ package, including the .PKGINFO as well as the buildinfo.
 For more details see https://reproducible-builds.org/
 
 OPTIONS
+    -d            Run diffoscope if the package is unreproducible
     -c <dir>      Set pacman cache
     -M <file>     Location of a makepkg config file
     -h            Show this usage message
 __EOF__
 }
 
-while getopts 'M:c:h' arg; do
+while getopts 'dM:c:h' arg; do
     case "$arg" in
+        d) diffoscope=1 ;;
         M) archroot_args+=(-M "$OPTARG") ;;
         c) cache_dirs+=("$OPTARG") ;;
         h) usage; exit 0 ;;
@@ -177,12 +180,17 @@ arch-nspawn "${buildroot}/${chroot}" \
 if (( $? == 0 )); then
     msg2 "built succeeded! built packages can be found in ${buildroot}/${chroot}/pkgdest"
     msg "comparing artifacts..."
-    if cmp -s "${pkgfile}" "${buildroot}/${chroot}/pkgdest/${pkgfile##*/}"; then
+
+    comparefiles=("${pkgfile}" "${buildroot}/${chroot}/pkgdest/${pkgfile##*/}")
+    if cmp -s "${comparefiles[@]}"; then
         msg2 "Package successfully reproduced!"
         exit 0
     else
         warning "Package is not reproducible. :("
-        sha256sum "${pkgfile}" "${buildroot}/${chroot}/pkgdest/${pkgfile##*/}"
+        sha256sum "${comparefiles[@]}"
+        if (( diffoscope )); then
+            diffoscope "${comparefiles[@]}"
+        fi
     fi
 fi
 
-- 
2.24.1

From eschwartz at archlinux.org  Mon Dec 16 20:46:09 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Mon, 16 Dec 2019 15:46:09 -0500
Subject: [arch-projects] [devtools] [PATCH 3/3] makerepropkg: support
 checking multiple split packages
In-Reply-To: <20191216204609.111647-1-eschwartz@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
Message-ID: <20191216204609.111647-4-eschwartz@archlinux.org>

By specifying multiple package files, we assume they are all from the
same PKGBUILD, and try to check them all against the produced artifacts.
Since the buildinfo should be comparable for all of them, we simply use
the first one passed on the command line.

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---
 doc/makerepropkg.1.asciidoc |  8 ++++++--
 makerepropkg.in             | 40 +++++++++++++++++++++----------------
 2 files changed, 29 insertions(+), 19 deletions(-)

diff --git a/doc/makerepropkg.1.asciidoc b/doc/makerepropkg.1.asciidoc
index 301b73e..0d7ddcb 100644
--- a/doc/makerepropkg.1.asciidoc
+++ b/doc/makerepropkg.1.asciidoc
@@ -7,12 +7,12 @@ makerepropkg - Rebuild a package to see if it is reproducible
 
 Synopsis
 --------
-makerepropkg [OPTIONS] <package_file>
+makerepropkg [OPTIONS] <package_file>...
 
 Description
 -----------
 
-Given the path to a built pacman package, attempt to rebuild it using the
+Given the path to a built pacman package(s), attempt to rebuild it using the
 PKGBUILD in the current directory. The package will be built in an environment
 as closely matching the environment of the initial package as possible, by
 building up a chroot to match the information exposed in the package's
@@ -20,6 +20,10 @@ linkman:BUILDINFO[5] manifest. On success, the resulting package will be
 compared to the input package, and makerepropkg will report whether the
 artifacts are identical.
 
+When given multiple packages, additional package files are assumed to be split
+packages and will be treated as additional artifacts to compare during the
+verification step.
+
 This implements a verifier for pacman/libalpm packages in accordance with the
 link:https://reproducible-builds.org/[Reproducible Builds] project.
 
diff --git a/makerepropkg.in b/makerepropkg.in
index 60fee95..51c2dd2 100755
--- a/makerepropkg.in
+++ b/makerepropkg.in
@@ -117,10 +117,13 @@ check_root
 
 if [[ -n $1 ]]; then
     pkgfile="$1"
-    if ! bsdtar -tqf "${pkgfile}" .BUILDINFO >/dev/null 2>&1; then
-        error "file is not a valid pacman package: '%s'" "${pkgfile}"
-        exit 1
-    fi
+    splitpkgs=("$@")
+    for f in "${splitpkgs[@]}"; do
+        if ! bsdtar -tqf "${f}" .BUILDINFO >/dev/null 2>&1; then
+            error "file is not a valid pacman package: '%s'" "${f}"
+            exit 1
+        fi
+    done
 else
     error "no package file specified. Try '${BASH_SOURCE[0]##*/} -h' for more information. "
     exit 1
@@ -176,23 +179,26 @@ arch-nspawn "${buildroot}/${chroot}" \
     --bind="${PWD}:/startdir" \
     --bind="${SRCDEST}:/srcdest" \
     /chrootbuild -C --noconfirm --log --holdver --skipinteg
+ret=$?
 
-if (( $? == 0 )); then
+if (( ${ret} == 0 )); then
     msg2 "built succeeded! built packages can be found in ${buildroot}/${chroot}/pkgdest"
     msg "comparing artifacts..."
 
-    comparefiles=("${pkgfile}" "${buildroot}/${chroot}/pkgdest/${pkgfile##*/}")
-    if cmp -s "${comparefiles[@]}"; then
-        msg2 "Package successfully reproduced!"
-        exit 0
-    else
-        warning "Package is not reproducible. :("
-        sha256sum "${comparefiles[@]}"
-        if (( diffoscope )); then
-            diffoscope "${comparefiles[@]}"
+    for pkgfile in "${splitpkgs[@]}"; do
+        comparefiles=("${pkgfile}" "${buildroot}/${chroot}/pkgdest/${pkgfile##*/}")
+        if cmp -s "${comparefiles[@]}"; then
+            msg2 "Package '%s' successfully reproduced!" "${pkgfile}"
+        else
+            ret=1
+            warning "Package '%s' is not reproducible. :(" "${pkgfile}"
+            sha256sum "${comparefiles[@]}"
+            if (( diffoscope )); then
+                diffoscope "${comparefiles[@]}"
+            fi
         fi
-    fi
+    done
 fi
 
-# the package either failed to build, or was unreproducible
-exit 1
+# return failure from chrootbuild, or the reproducibility status
+exit ${ret}
-- 
2.24.1

From eschwartz at archlinux.org  Mon Dec 16 20:46:06 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Mon, 16 Dec 2019 15:46:06 -0500
Subject: [arch-projects] [devtools] [PATCH 0/3] makerepropkg improvements
Message-ID: <20191216204609.111647-1-eschwartz@archlinux.org>

Available at https://github.com/eli-schwartz/devtools/commits/makerepropkg-diffoscope



Eli Schwartz (3):
  makerepropkg: fix wonky indent
  makerepropkg: add support to check unreproducible packages using
    diffoscope
  makerepropkg: support checking multiple split packages

 doc/makerepropkg.1.asciidoc | 11 ++++++--
 makerepropkg.in             | 56 +++++++++++++++++++++++--------------
 2 files changed, 44 insertions(+), 23 deletions(-)

-- 
2.24.1

From anthraxx at archlinux.org  Mon Dec 16 20:53:54 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Mon, 16 Dec 2019 21:53:54 +0100
Subject: [arch-projects] [devtools] [PATCH 2/3] makerepropkg: add
 support to check unreproducible packages using diffoscope
In-Reply-To: <20191216204609.111647-3-eschwartz@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
 <20191216204609.111647-3-eschwartz@archlinux.org>
Message-ID: <89AE0E74-860D-4C7D-94ED-DBD843EE3B73@archlinux.org>

Please add the new option to zsh_completions.in

From anthraxx at archlinux.org  Mon Dec 16 20:55:17 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Mon, 16 Dec 2019 21:55:17 +0100
Subject: [arch-projects] [devtools] [PATCH 3/3] makerepropkg: support
 checking multiple split packages
In-Reply-To: <20191216204609.111647-4-eschwartz@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
 <20191216204609.111647-4-eschwartz@archlinux.org>
Message-ID: <6A6D50DE-2AE9-4DF6-8357-823B58FA2700@archlinux.org>

Please adjust zsh_completions.in to take multiple packages in _makerepropkg_args

From eschwartz at archlinux.org  Thu Dec 19 21:19:43 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Thu, 19 Dec 2019 16:19:43 -0500
Subject: [arch-projects] [devtools] [PATCH 3/3] makerepropkg: support
 checking multiple split packages
In-Reply-To: <6A6D50DE-2AE9-4DF6-8357-823B58FA2700@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
 <20191216204609.111647-4-eschwartz@archlinux.org>
 <6A6D50DE-2AE9-4DF6-8357-823B58FA2700@archlinux.org>
Message-ID: <c3a2acd6-b874-22ec-2134-2f2fb71ae99a@archlinux.org>

On 12/16/19 3:55 PM, Levente Polyak via arch-projects wrote:
> Please adjust zsh_completions.in to take multiple packages in _makerepropkg_args

I'm not a zsh user, and I don't know what this means and therefore
cannot implement it. Maybe you could do it instead, since you're the one
who has been recently authoring changes to that file?

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/arch-projects/attachments/20191219/66206d94/attachment.sig>

From anthraxx at archlinux.org  Thu Dec 19 22:02:14 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Thu, 19 Dec 2019 23:02:14 +0100
Subject: [arch-projects] [devtools] [PATCH 3/3] makerepropkg: support
 checking multiple split packages
In-Reply-To: <c3a2acd6-b874-22ec-2134-2f2fb71ae99a@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
 <20191216204609.111647-4-eschwartz@archlinux.org>
 <6A6D50DE-2AE9-4DF6-8357-823B58FA2700@archlinux.org>
 <c3a2acd6-b874-22ec-2134-2f2fb71ae99a@archlinux.org>
Message-ID: <965F1B28-A769-4720-9E5E-289B51CE2355@archlinux.org>

On December 19, 2019 10:19:43 PM GMT+01:00, Eli Schwartz via arch-projects <arch-projects at archlinux.org> wrote:
>On 12/16/19 3:55 PM, Levente Polyak via arch-projects wrote:
>> Please adjust zsh_completions.in to take multiple packages in
>_makerepropkg_args
>
>I'm not a zsh user, and I don't know what this means and therefore
>cannot implement it. Maybe you could do it instead, since you're the
>one
>who has been recently authoring changes to that file?

Just replace the 1 with a asterisk * where I mentioned it. 
I'm not really into fixing up all commits people contribute to keep the integrity of completion that I once cleaned and synced to the current state. 

From eschwartz at archlinux.org  Thu Dec 19 23:37:10 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Thu, 19 Dec 2019 18:37:10 -0500
Subject: [arch-projects] [devtools] [PATCH 3/3] makerepropkg: support
 checking multiple split packages
In-Reply-To: <965F1B28-A769-4720-9E5E-289B51CE2355@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
 <20191216204609.111647-4-eschwartz@archlinux.org>
 <6A6D50DE-2AE9-4DF6-8357-823B58FA2700@archlinux.org>
 <c3a2acd6-b874-22ec-2134-2f2fb71ae99a@archlinux.org>
 <965F1B28-A769-4720-9E5E-289B51CE2355@archlinux.org>
Message-ID: <58071053-846c-a8ed-e538-ea8166999ff7@archlinux.org>

On 12/19/19 5:02 PM, Levente Polyak via arch-projects wrote:
> Just replace the 1 with a asterisk * where I mentioned it.
> 
> I'm not really into fixing up all commits people contribute to keep
> the integrity of completion that I once cleaned and synced to the
> current state.

I'm not really into having contributions blocked contingent on me
learning zsh.

...

It's nice that you're personally motivated to update zsh completions,
but it would mean more to me if you had the same care and concern for
the rotting bash completions, which is what *I* care about, since bash
is the shell I know and use. (That, however, is not a current priority
for me, so it goes onto the endless TODO list.)

This shows me that you're asking for zsh completions because you're
enthusiastic about zsh on a personal level, not because there's a
fundamental goal that the project needs to have up to date completions. :(

In the meantime, spoonfeeding me the actual diff you want for this file
and asking me to submit it with my name slapped on as the author feels
sort of silly to me. Nevertheless, if you tell me what the range diff
should be for "Please add the new option to zsh_completions.in", I will
be happy to combine that with replacing the "1" character with a "*" as
advised above, and submit a third patch that updates the completions for
your shell of choice (but no others).

Tell me exactly what to do and I'll do it. :)

...

All I can imagine now is submitting a feature to a project and being
told "sorry, we won't accept this unless you also submit updated gettext
translations for this list of 30 languages".

This is why projects usually have dedicated stakeholders to maintain
select integration features that aren't the core project and ensure they
are kept up to date with the rest of the codebase.

And those stakeholders do their work after features are merged, and if
they don't show up to do the work, the project can still be updated and
released.

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/arch-projects/attachments/20191219/f6ff57ec/attachment.sig>

From anthraxx at archlinux.org  Thu Dec 19 23:49:22 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Fri, 20 Dec 2019 00:49:22 +0100
Subject: [arch-projects] [devtools] [PATCH 3/3] makerepropkg: support
 checking multiple split packages
In-Reply-To: <58071053-846c-a8ed-e538-ea8166999ff7@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
 <20191216204609.111647-4-eschwartz@archlinux.org>
 <6A6D50DE-2AE9-4DF6-8357-823B58FA2700@archlinux.org>
 <c3a2acd6-b874-22ec-2134-2f2fb71ae99a@archlinux.org>
 <965F1B28-A769-4720-9E5E-289B51CE2355@archlinux.org>
 <58071053-846c-a8ed-e538-ea8166999ff7@archlinux.org>
Message-ID: <0E2FA5F1-02E7-4BF9-9BF7-A64CD6A222E0@archlinux.org>

You are u justified ranting here for a whole wall of text instead of editing a simple text file that anyone can understand with zero knowledge of the specifics.
Its a part of the toolkit to the same degree as man pages are. We are also not wanting to soften up the integrity of man pages just because a contributor never touched man pages. You are more then capable of editing a single line in a text file you not fully know every detail about just by purely observing to the same degree I was able to restore its integrity without ever having done zsh completions before.
Its not the responsibility of the maintainers to fix up man pages and completions for all eternity whe also offering help and hints how to adjust them when people don't know a out them.
I restored the zsh integrity and I'm happy to point people to how to keep them in tact with their changes but I'm not a cleanup boy because someone is too lazy to change a text file. 

From anthraxx at archlinux.org  Fri Dec 20 00:14:32 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Fri, 20 Dec 2019 01:14:32 +0100
Subject: [arch-projects] [devtools] [PATCH 3/3] makerepropkg: support
 checking multiple split packages
In-Reply-To: <58071053-846c-a8ed-e538-ea8166999ff7@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
 <20191216204609.111647-4-eschwartz@archlinux.org>
 <6A6D50DE-2AE9-4DF6-8357-823B58FA2700@archlinux.org>
 <c3a2acd6-b874-22ec-2134-2f2fb71ae99a@archlinux.org>
 <965F1B28-A769-4720-9E5E-289B51CE2355@archlinux.org>
 <58071053-846c-a8ed-e538-ea8166999ff7@archlinux.org>
Message-ID: <628C3845-8114-4843-8E29-E9AADD5EC2EB@archlinux.org>

On December 20, 2019 12:37:10 AM GMT+01:00, Eli Schwartz via arch-projects <arch-projects at archlinux.org> wrote:
>It's nice that you're personally motivated to update zsh completions,
>but it would mean more to me if you had the same care and concern for
>the rotting bash completions, which is what *I* care about, since bash
>is the shell I know and use. (That, however, is not a current priority
>for me, so it goes onto the endless TODO list.)
>
>This shows me that you're asking for zsh completions because you're
>enthusiastic about zsh on a personal level, not because there's a
>fundamental goal that the project needs to have up to date completions.
>:(
>


And to respond to this explicitly, no, this is false. I care a out the integrity
of the specific parts and not to purely suite the variant I by accident use
as well. Fixing bash completions is still on my list as well and once it's
up to date it should also be aimed to fix up on changes. The truth is as
simple as bash completions being a total mess (at least the one we have
in the repo) compared to the zsh completion we have there so within the
time frame I prioritized bringing the zsh variant back to shape was way
easier even through I have way less zsh specific knowledge compared to
having bash related knowledge.
Once bash is in tact as well I have the very exact same feelings about its
integrity as I do right now for zsh, purely to sustain integrity in the
projects components itself from a maintainer view rather than *any*
personal choice or preference, because my personal preference doesn't
matter when having the maintainer hat on. 

From eschwartz at archlinux.org  Fri Dec 20 00:25:57 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Thu, 19 Dec 2019 19:25:57 -0500
Subject: [arch-projects] [devtools] [PATCH 3/3] makerepropkg: support
 checking multiple split packages
In-Reply-To: <0E2FA5F1-02E7-4BF9-9BF7-A64CD6A222E0@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
 <20191216204609.111647-4-eschwartz@archlinux.org>
 <6A6D50DE-2AE9-4DF6-8357-823B58FA2700@archlinux.org>
 <c3a2acd6-b874-22ec-2134-2f2fb71ae99a@archlinux.org>
 <965F1B28-A769-4720-9E5E-289B51CE2355@archlinux.org>
 <58071053-846c-a8ed-e538-ea8166999ff7@archlinux.org>
 <0E2FA5F1-02E7-4BF9-9BF7-A64CD6A222E0@archlinux.org>
Message-ID: <057f57c0-2a6e-58bd-a96c-1be81a05052f@archlinux.org>

On 12/19/19 6:49 PM, Levente Polyak via arch-projects wrote:
> You are u justified ranting here for a whole wall of text

And you are unjustified in ranting here for a single sentence about how
you're "not into fixing up the precious integrity of my precious that
you're ruining by submitting PRs". It's seriously demotivating.

I'll consider only doing my rants via pithy one-liners in the future.

> instead of editing a simple text file that anyone can understand
> with zero knowledge of the specifics.

Untrue, or are you suggesting I either understood or now currently
understand where and why to use a "1" or a "*" in your previous
recommendation "with zero knowledge of the specifics"?

How do you propose I test the changes, what makes you think I have zsh
installed at all, much less configured to initialize completions
(however that is done)?

> Its a part of the toolkit to the same degree as man pages are. We are
> also not wanting to soften up the integrity of man pages just because
> a contributor never touched man pages.

Man pages are prose, not code, so I expect that to be a lot easier. And
if someone submits a man page update with incorrect asciidoc formatting,
then 99% of the patch would still be correct and I'd be happy as a
project maintainer to fix the rest.

This is assuming that the formatting issues aren't of the variety that
causes "make all" to fail. It's not hard to update *prose* when there's
a Makefile target to prove it works, and when every user is expected to
know how to run "man".

This is quite aside for the fact that most devtools programs don't have
manpages at all, so it's a non-issue.

> Its not the responsibility of the maintainers to fix up man pages
> and completions for all eternity

It's not the job of the maintainers. It's the job of the zsh users. You
happen to be both.

I didn't say it's your responsibility to fix up bash completions for all
eternity either -- that would be my job as a concerned bash user, and
I'll take my lumps for not being on the ball for it.

> whe also offering help and hints how to adjust them when people don't
> know a out them. I restored the zsh integrity and I'm happy to point
> people to how to keep them in tact with their changes but I'm not a
> cleanup boy because someone is too lazy to change a text file.

Sure, and by the same definition of a zsh script as "just a text file"
the linux kernel is just a bunch of text files, I guess anyone who
doesn't contribute changes there is too lazy?

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/arch-projects/attachments/20191219/aff88cbc/attachment-0001.sig>

From anthraxx at archlinux.org  Fri Dec 20 00:48:11 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Fri, 20 Dec 2019 01:48:11 +0100
Subject: [arch-projects] [devtools] [PATCH 3/3] makerepropkg: support
 checking multiple split packages
In-Reply-To: <057f57c0-2a6e-58bd-a96c-1be81a05052f@archlinux.org>
References: <20191216204609.111647-1-eschwartz@archlinux.org>
 <20191216204609.111647-4-eschwartz@archlinux.org>
 <6A6D50DE-2AE9-4DF6-8357-823B58FA2700@archlinux.org>
 <c3a2acd6-b874-22ec-2134-2f2fb71ae99a@archlinux.org>
 <965F1B28-A769-4720-9E5E-289B51CE2355@archlinux.org>
 <58071053-846c-a8ed-e538-ea8166999ff7@archlinux.org>
 <0E2FA5F1-02E7-4BF9-9BF7-A64CD6A222E0@archlinux.org>
 <057f57c0-2a6e-58bd-a96c-1be81a05052f@archlinux.org>
Message-ID: <719995E5-2226-484D-9DA2-9C1A83EFDCBE@archlinux.org>

On December 20, 2019 1:25:57 AM GMT+01:00, Eli Schwartz via arch-projects <arch-projects at archlinux.org> wrote:
>On 12/19/19 6:49 PM, Levente Polyak via arch-projects wrote:
>> You are u justified ranting here for a whole wall of text
>
>And you are unjustified in ranting here for a single sentence about how
>you're "not into fixing up the precious integrity of my precious that
>you're ruining by submitting PRs". It's seriously demotivating.
>
>I'll consider only doing my rants via pithy one-liners in the future.
>
>> instead of editing a simple text file that anyone can understand
>> with zero knowledge of the specifics.
>
>Untrue, or are you suggesting I either understood or now currently
>understand where and why to use a "1" or a "*" in your previous
>recommendation "with zero knowledge of the specifics"?
>

Yes and that's why I helped you out with a simple answer to the question how to do it. 


>How do you propose I test the changes, what makes you think I have zsh
>installed at all, much less configured to initialize completions
>(however that is done)?
>

Seriously, look at that completion. I'm confident you have the technical competence to add a new option that simply works and it's a review here after all. 


>> Its a part of the toolkit to the same degree as man pages are. We are
>> also not wanting to soften up the integrity of man pages just because
>> a contributor never touched man pages.
>
>Man pages are prose, not code, so I expect that to be a lot easier. And
>if someone submits a man page update with incorrect asciidoc
>formatting,
>then 99% of the patch would still be correct and I'd be happy as a
>project maintainer to fix the rest.
>
>This is assuming that the formatting issues aren't of the variety that
>causes "make all" to fail. It's not hard to update *prose* when there's
>a Makefile target to prove it works, and when every user is expected to
>know how to run "man".
>
>This is quite aside for the fact that most devtools programs don't have
>manpages at all, so it's a non-issue.
>

Yep very happy you did the patches but it would be awesome of a frequent
contributor to also do the simple completion thingies. If it's something
unjustified complex that would be fine by me, but it's literally someone
so simple anyone can easily comprehend. I would prefer helping
contributors to get to a point where doing man pages and completions
is just part of a PR. 

Please for the sake of the project let's just get over this debate and get
a copy paste line for the new option into the completion file. I'm confident
you will do it properly in under 10 seconds, I know you well enough
to be able to judge that it's a zero brainer for you. 

Cheers and happy to include your series, 
anthraxx 

From jouke at archlinux.org  Wed Dec 25 13:18:34 2019
From: jouke at archlinux.org (Jouke Witteveen)
Date: Wed, 25 Dec 2019 13:18:34 +0000 (UTC)
Subject: [arch-projects] [netctl] [GIT] Network control utility based on
 systemd branch master updated. 1.20-2-gc019679
Message-ID: <20191225131834.7F9552B787@luna.archlinux.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Network control utility based on systemd".

The branch, master has been updated
       via  c0196798dde620566146867e59d52d3120e9b4f1 (commit)
       via  89cba954bef7c370ea38f9c0ca087f816620d62b (commit)
      from  7cb0a5ab146f3c26bc05706bda7e3e662af5408a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c0196798dde620566146867e59d52d3120e9b4f1
Author: Christian Hesse <mail at eworm.de>
Date:   Wed Nov 13 12:15:35 2019 +0000

    base group removal

commit 89cba954bef7c370ea38f9c0ca087f816620d62b
Author: Antonio Rojas <arojas at archlinux.org>
Date:   Wed Jun 26 16:22:35 2019 +0200

    PKGBUILD: use https for the url

-----------------------------------------------------------------------

Summary of changes:
 contrib/PKGBUILD.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


hooks/post-receive
-- 
Network control utility based on systemd

From anthraxx at archlinux.org  Fri Dec 27 15:07:38 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Fri, 27 Dec 2019 15:07:38 +0000 (UTC)
Subject: [arch-projects] [devtools] [GIT] The official devtools repository
 branch master updated. 20191212-3-g74d7a70
Message-ID: <20191227150738.4110C2B391@luna.archlinux.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The official devtools repository".

The branch, master has been updated
       via  74d7a70915d7143938f560e6f7051e0147855d3f (commit)
       via  5eacb475cd1a92dc4fdaf25f86984da74a23f5ab (commit)
       via  bcda211dd86b3bf54a9bc40d2e19f1aad4bbfbb8 (commit)
      from  d4546c59ce2731a96d336f9953108816ff4b954b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 74d7a70915d7143938f560e6f7051e0147855d3f
Author: Levente Polyak <anthraxx at archlinux.org>
Date:   Fri Dec 27 16:06:30 2019 +0100

    Version 20191227

commit 5eacb475cd1a92dc4fdaf25f86984da74a23f5ab
Author: Robin Broda <robin at broda.me>
Date:   Sat Dec 14 19:25:00 2019 +0100

    makerepopkg: fix zstd extension (.zstd -> .zst)

commit bcda211dd86b3bf54a9bc40d2e19f1aad4bbfbb8
Author: Robin Broda <robin at broda.me>
Date:   Sat Dec 14 19:25:46 2019 +0100

    makepkg.conf: change default compression method to zstd

-----------------------------------------------------------------------

Summary of changes:
 Makefile            | 2 +-
 makepkg-x86_64.conf | 4 ++--
 makerepropkg.in     | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
The official devtools repository

From anthraxx at archlinux.org  Fri Dec 27 15:07:43 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Fri, 27 Dec 2019 15:07:43 +0000 (UTC)
Subject: [arch-projects] [devtools] [GIT] The official devtools repository
 annotated tag 20191227 created. 20191227
Message-ID: <20191227150743.E5E562B391@luna.archlinux.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The official devtools repository".

The annotated tag, 20191227 has been created
        at  2304c51f99fd4b06a43de97ccb61b03532d8265b (tag)
   tagging  74d7a70915d7143938f560e6f7051e0147855d3f (commit)
  replaces  20191212
 tagged by  Levente Polyak
        on  Fri Dec 27 16:06:30 2019 +0100

- Log -----------------------------------------------------------------
Version 20191227
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE4kC1fixGMLp2ji8m/BtUfI2BcsgFAl4GHfYACgkQ/BtUfI2B
csjulg//aRqDfwA5/FihptiY3aPH9GlOeWai/ikV1djfMjdie0kkjsWviHACr1bK
TggToyVKO1xq2oMO3oauO+/5dLMdE/TTsMHhrFkt6aFXD2Xm2LNKN2BsolAktmAU
vFF6F2mZJzKrRVglA5q/QjfDaWGMgKMu03no2Ei3yTjjCZwLucxl2xfb9PuCldYo
HD06ZEI5TsM/gkXRgobVTXvIdHFtXUgrcFKwlJ3RnfKfoPHxNbfKHJII+ZupTgbE
k9B1xVoErIItrDS8ZGaU6tqysYlOkfrtYlvdyu23eBIrkPJ1yrkYQsYXcWp8yA54
iZsD2SbUwW9xzEUjHfq3+VqGsn8MIpz9sDbwR06GZ849S2JKLTuikjDYzQY62m7j
498F+VCazWizn7koQaYcKGdAwB+HCrd5FR7Hgmf3yDTfzWC+lpiQMq1/P0lz7azT
DXxM0SH8/ei7ptsIOrSzri+R5+UH/ryKLBIQyN9xfB/FkDmZ3oPCumu82KRI3Q38
MwCmcWFsUOImSIWVcnh/akyqC86NoLsIR67f5r8Tu6A++LvbYQ4ifiS5QizKE4b3
4vtuGGdqxoTobWPsNsnjZbJNxcE+idlD64UZhu3MoiRqjkAB+5MWgBwdB95TD0Qm
j3q4lKBVBt3mmsYOl4FaPdEvJx3LkT9Mi1yhrmGA2NCYFgS8kuY=
=k9jN
-----END PGP SIGNATURE-----

Levente Polyak (1):
      Version 20191227

Robin Broda (2):
      makepkg.conf: change default compression method to zstd
      makerepopkg: fix zstd extension (.zstd -> .zst)

-----------------------------------------------------------------------


hooks/post-receive
-- 
The official devtools repository

From eschwartz at archlinux.org  Fri Dec 27 17:08:30 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Fri, 27 Dec 2019 12:08:30 -0500
Subject: [arch-projects] [devtools] [PATCH] makerepropkg: correctly
 reproduce a pkgfile with any compression type
Message-ID: <20191227170830.1154340-1-eschwartz@archlinux.org>

We don't want the default PKGEXT in the current version of devtools, we
want the PKGEXT we *know* the input file used.

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---
 makerepropkg.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/makerepropkg.in b/makerepropkg.in
index 51c2dd2..0721f65 100755
--- a/makerepropkg.in
+++ b/makerepropkg.in
@@ -144,6 +144,9 @@ export SOURCE_DATE_EPOCH="${buildinfo[builddate]}"
 PACKAGER="${buildinfo[packager]}"
 BUILDDIR="${buildinfo[builddir]}"
 
+trimprefix=${pkgfile%.pkg.tar*}
+PKGEXT=${pkgfile#$trimprefix}
+
 # nuke and restore reproducible testenv
 for copy in "${buildroot}"/*/; do
     [[ -d ${copy} ]] || continue
@@ -166,7 +169,7 @@ makechrootpkg -r "${buildroot}" -l "${chroot}" -- --packagelist || exit 1
 
 # set detected makepkg.conf options
 {
-    for var in PACKAGER BUILDDIR; do
+    for var in PACKAGER BUILDDIR PKGEXT; do
         printf '%s=%s\n' "${var}" "${!var at Q}"
     done
     printf 'OPTIONS=(%s)\n' "${buildopts[*]@Q}"
-- 
2.24.1

From eschwartz at archlinux.org  Fri Dec 27 17:41:41 2019
From: eschwartz at archlinux.org (Eli Schwartz)
Date: Fri, 27 Dec 2019 12:41:41 -0500
Subject: [arch-projects] [devtools] [PATCH v2] makerepropkg: correctly
 reproduce a pkgfile with any compression type
In-Reply-To: <20191227170830.1154340-1-eschwartz@archlinux.org>
References: <20191227170830.1154340-1-eschwartz@archlinux.org>
Message-ID: <20191227174141.3018-1-eschwartz@archlinux.org>

We don't want the default PKGEXT in the current version of devtools, we
want the PKGEXT we *know* the input file used.

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
---

v2: use one less line when defining PKGEXT, as per anthraxx review

 makerepropkg.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/makerepropkg.in b/makerepropkg.in
index 40806cb..121456c 100755
--- a/makerepropkg.in
+++ b/makerepropkg.in
@@ -137,6 +137,7 @@ parse_buildinfo < <(bsdtar -xOqf "${pkgfile}" .BUILDINFO)
 export SOURCE_DATE_EPOCH="${buildinfo[builddate]}"
 PACKAGER="${buildinfo[packager]}"
 BUILDDIR="${buildinfo[builddir]}"
+PKGEXT=${pkgfile#${pkgfile%.pkg.tar*}}
 
 # nuke and restore reproducible testenv
 for copy in "${buildroot}"/*/; do
@@ -160,7 +161,7 @@ makechrootpkg -r "${buildroot}" -l "${chroot}" -- --packagelist || exit 1
 
 # set detected makepkg.conf options
 {
-    for var in PACKAGER BUILDDIR; do
+    for var in PACKAGER BUILDDIR PKGEXT; do
         printf '%s=%s\n' "${var}" "${!var at Q}"
     done
     printf 'OPTIONS=(%s)\n' "${buildopts[*]@Q}"
-- 
2.24.1

From anthraxx at archlinux.org  Fri Dec 27 18:43:01 2019
From: anthraxx at archlinux.org (Levente Polyak)
Date: Fri, 27 Dec 2019 18:43:01 +0000 (UTC)
Subject: [arch-projects] [devtools] [GIT] The official devtools repository
 branch master updated. 20191227-1-g4c08847
Message-ID: <20191227184301.4B3DC20F16@luna.archlinux.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The official devtools repository".

The branch, master has been updated
       via  4c08847bfa7776abb884fef289a25c1cef9883fb (commit)
      from  74d7a70915d7143938f560e6f7051e0147855d3f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4c08847bfa7776abb884fef289a25c1cef9883fb
Author: Eli Schwartz <eschwartz at archlinux.org>
Date:   Fri Dec 27 11:59:48 2019 -0500

    makerepropkg: correctly reproduce a pkgfile with any compression type
    
    We don't want the default PKGEXT in the current version of devtools, we
    want the PKGEXT we *know* the input file used.
    
    Signed-off-by: Levente Polyak <anthraxx at archlinux.org>

-----------------------------------------------------------------------

Summary of changes:
 makerepropkg.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
The official devtools repository