[arch-projects] [devtools] [PATCH 3/3] makerepropkg: support checking multiple split packages

Levente Polyak anthraxx at archlinux.org
Fri Dec 20 00:48:11 UTC 2019


On December 20, 2019 1:25:57 AM GMT+01:00, Eli Schwartz via arch-projects <arch-projects at archlinux.org> wrote:
>On 12/19/19 6:49 PM, Levente Polyak via arch-projects wrote:
>> You are u justified ranting here for a whole wall of text
>
>And you are unjustified in ranting here for a single sentence about how
>you're "not into fixing up the precious integrity of my precious that
>you're ruining by submitting PRs". It's seriously demotivating.
>
>I'll consider only doing my rants via pithy one-liners in the future.
>
>> instead of editing a simple text file that anyone can understand
>> with zero knowledge of the specifics.
>
>Untrue, or are you suggesting I either understood or now currently
>understand where and why to use a "1" or a "*" in your previous
>recommendation "with zero knowledge of the specifics"?
>

Yes and that's why I helped you out with a simple answer to the question how to do it. 


>How do you propose I test the changes, what makes you think I have zsh
>installed at all, much less configured to initialize completions
>(however that is done)?
>

Seriously, look at that completion. I'm confident you have the technical competence to add a new option that simply works and it's a review here after all. 


>> Its a part of the toolkit to the same degree as man pages are. We are
>> also not wanting to soften up the integrity of man pages just because
>> a contributor never touched man pages.
>
>Man pages are prose, not code, so I expect that to be a lot easier. And
>if someone submits a man page update with incorrect asciidoc
>formatting,
>then 99% of the patch would still be correct and I'd be happy as a
>project maintainer to fix the rest.
>
>This is assuming that the formatting issues aren't of the variety that
>causes "make all" to fail. It's not hard to update *prose* when there's
>a Makefile target to prove it works, and when every user is expected to
>know how to run "man".
>
>This is quite aside for the fact that most devtools programs don't have
>manpages at all, so it's a non-issue.
>

Yep very happy you did the patches but it would be awesome of a frequent
contributor to also do the simple completion thingies. If it's something
unjustified complex that would be fine by me, but it's literally someone
so simple anyone can easily comprehend. I would prefer helping
contributors to get to a point where doing man pages and completions
is just part of a PR. 

Please for the sake of the project let's just get over this debate and get
a copy paste line for the new option into the completion file. I'm confident
you will do it properly in under 10 seconds, I know you well enough
to be able to judge that it's a zero brainer for you. 

Cheers and happy to include your series, 
anthraxx 


More information about the arch-projects mailing list