[arch-projects] [namcap] [PATCH 3/4] nonuniquesources: Also warn on common filenames not overriding name to be unique

Eli Schwartz eschwartz at archlinux.org
Mon May 27 02:48:25 UTC 2019


On 5/26/19 10:35 PM, James Harvey via arch-projects wrote:
> Filenames in source() are required to be unique.  A common violation of
> this is from commonly named files (i.e. LICENSE) that aren't part of an
> upstream tarball.
> 
> Warn if a source file doesn't have an overriding name, and has a
> commonly used name, ignoring extension and case.
> 
> Signed-off-by: James P. Harvey <jamespharvey20 at gmail dot com>
> 
> Namcap/rules/nonuniquesources.py | 22 ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)

I expect the common case of files named "LICENSE", to be distributed
with the PKGBUILD rather than downloaded, in which case it will *always*
be unique (for the same reason "PKGBUILD" is unique).

The check would need to first make sure that there is a positively
existing download protocol.a


-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/arch-projects/attachments/20190526/e276ae0a/attachment.sig>


More information about the arch-projects mailing list